Skip to content

Commit 848b794

Browse files
author
OpenShift Bot
authored
Merge pull request #1033 from jwforres/next-steps-redirect
Merged by openshift-bot
2 parents 9ab85d9 + b0892de commit 848b794

File tree

2 files changed

+13
-10
lines changed

2 files changed

+13
-10
lines changed

Diff for: app/scripts/controllers/create/nextSteps.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,13 @@ angular.module("openshiftConsole")
2727

2828
var template = $routeParams.template;
2929
var nameLink = "";
30+
var name = "";
3031
if (creatingFromImage()) {
3132
nameLink = "project/" + $scope.projectName + "/create/fromimage?imageName=" + imageName + "&imageTag=" + imageTag + "&namespace=" + namespace + "&name=" + name;
33+
name = imageName + ":" + imageTag;
3234
} else if (creatingFromTemplate()) {
3335
nameLink = "project/" + $scope.projectName + "/create/fromtemplate?template=" + template + "&namespace=" + namespace;
36+
name = template;
3437
}
3538

3639
$scope.breadcrumbs = [
@@ -120,7 +123,7 @@ angular.module("openshiftConsole")
120123
}));
121124

122125
function creatingFromTemplate() {
123-
return name && namespace;
126+
return template && namespace;
124127
}
125128

126129
function creatingFromImage() {

Diff for: dist/scripts/scripts.js

+9-9
Original file line numberDiff line numberDiff line change
@@ -7870,7 +7870,7 @@ f.then(j, j).then(F, F);
78707870
}));
78717871
} ]), angular.module("openshiftConsole").controller("NextStepsController", [ "$scope", "$http", "$routeParams", "DataService", "$q", "$location", "ProcessedTemplateService", "TaskList", "$parse", "Navigate", "Logger", "$filter", "imageObjectRefFilter", "failureObjectNameFilter", "ProjectsService", function(a, b, c, d, e, f, g, h, i, j, k, l, m, n, o) {
78727872
function p() {
7873-
return name && u;
7873+
return v && u;
78747874
}
78757875
function q() {
78767876
return s && t && u;
@@ -7879,23 +7879,23 @@ var r = (l("displayName"), []);
78797879
a.emptyMessage = "Loading...", a.alerts = [], a.loginBaseUrl = d.openshiftAPIBaseUrl(), a.buildConfigs = {}, a.showParamsTable = !1, a.projectName = c.project;
78807880
var s = c.imageStream, t = c.imageTag, u = c.namespace;
78817881
a.fromSampleRepo = c.fromSample;
7882-
var v = c.template, w = "";
7883-
q() ? w = "project/" + a.projectName + "/create/fromimage?imageName=" + s + "&imageTag=" + t + "&namespace=" + u + "&name=" + name :p() && (w = "project/" + a.projectName + "/create/fromtemplate?template=" + v + "&namespace=" + u), a.breadcrumbs = [ {
7882+
var v = c.template, w = "", x = "";
7883+
q() ? (w = "project/" + a.projectName + "/create/fromimage?imageName=" + s + "&imageTag=" + t + "&namespace=" + u + "&name=" + x, x = s + ":" + t) :p() && (w = "project/" + a.projectName + "/create/fromtemplate?template=" + v + "&namespace=" + u, x = v), a.breadcrumbs = [ {
78847884
title:a.projectName,
78857885
link:"project/" + a.projectName
78867886
}, {
78877887
title:"Add to Project",
78887888
link:"project/" + a.projectName + "/create"
78897889
}, {
7890-
title:name,
7890+
title:x,
78917891
link:w
78927892
}, {
78937893
title:"Next Steps"
78947894
} ];
7895-
var x = g.getTemplateData();
7896-
a.parameters = x.params, _.each(a.parameters, function(a) {
7895+
var y = g.getTemplateData();
7896+
a.parameters = y.params, _.each(a.parameters, function(a) {
78977897
l("altTextForValueFrom")(a);
7898-
}), a.templateMessage = x.message, g.clearTemplateData(), o.get(c.project).then(_.spread(function(b, c) {
7898+
}), a.templateMessage = y.message, g.clearTemplateData(), o.get(c.project).then(_.spread(function(b, c) {
78997899
function e(a) {
79007900
var b = [];
79017901
return angular.forEach(a, function(a) {
@@ -7908,8 +7908,8 @@ return angular.forEach(a, function(a) {
79087908
"completed" !== a.status && b.push(a);
79097909
}), b;
79107910
}
7911-
return a.project = b, a.breadcrumbs[0].title = l("displayName")(b), name ? (r.push(d.watch("buildconfigs", c, function(b) {
7912-
a.buildConfigs = b.by("metadata.name"), a.createdBuildConfig = a.buildConfigs[name], k.log("buildconfigs (subscribe)", a.buildConfigs);
7911+
return a.project = b, a.breadcrumbs[0].title = l("displayName")(b), x ? (r.push(d.watch("buildconfigs", c, function(b) {
7912+
a.buildConfigs = b.by("metadata.name"), a.createdBuildConfig = a.buildConfigs[x], k.log("buildconfigs (subscribe)", a.buildConfigs);
79137913
})), a.createdBuildConfigWithGitHubTrigger = function() {
79147914
return _.some(_.get(a, "createdBuildConfig.spec.triggers"), {
79157915
type:"GitHub"

0 commit comments

Comments
 (0)