Skip to content

Commit 8498bca

Browse files
author
OpenShift Bot
authored
Merge pull request #2194 from spadgett/dont-dismiss-router-hostname-msg
Merged by openshift-bot
2 parents 002a70f + bac657d commit 8498bca

File tree

4 files changed

+2
-16
lines changed

4 files changed

+2
-16
lines changed

app/scripts/controllers/route.js

-5
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,6 @@ angular.module('openshiftConsole')
7272
return !AlertMessageService.isAlertPermanentlyHidden(alertKey, $scope.projectName);
7373
};
7474

75-
$scope.hideRouterHostnameAlert = function(ingress) {
76-
var alertKey = routerHostnameAlertKey(ingress);
77-
AlertMessageService.permanentlyHideAlert(alertKey, $scope.projectName);
78-
};
79-
8075
ProjectsService
8176
.get($routeParams.project)
8277
.then(_.spread(function(project, context) {

app/views/browse/route.html

+2-5
Original file line numberDiff line numberDiff line change
@@ -82,11 +82,8 @@ <h1 class="contains-actions">
8282
<div ng-if="showRouterHostnameAlert(ingress, admittedCondition)" class="mar-top-lg">
8383
<div class="alert alert-info">
8484
<span class="pficon pficon-info" aria-hidden="true"></span>
85-
<span class="mar-right-sm">
86-
The DNS admin should set up a CNAME from the route's hostname, {{ingress.host}},
87-
to the router's canonical hostname, {{ingress.routerCanonicalHostname}}.
88-
</span>
89-
<a href="" ng-click="hideRouterHostnameAlert(ingress)" role="button" class="nowrap">Don't Show Me Again</a>
85+
The DNS admin should set up a CNAME from the route's hostname, {{ingress.host}},
86+
to the router's canonical hostname, {{ingress.routerCanonicalHostname}}.
9087
</div>
9188
</div>
9289
</div>

dist/scripts/scripts.js

-3
Original file line numberDiff line numberDiff line change
@@ -6475,9 +6475,6 @@ if (!t || !t.host || !t.routerCanonicalHostname) return !1;
64756475
if (!n || "True" !== n.status) return !1;
64766476
var r = u(t);
64776477
return !a.isAlertPermanentlyHidden(r, e.projectName);
6478-
}, e.hideRouterHostnameAlert = function(t) {
6479-
var n = u(t);
6480-
a.permanentlyHideAlert(n, e.projectName);
64816478
}, o.get(n.project).then(_.spread(function(a, o) {
64826479
e.project = a, r.get("routes", n.route, o, {
64836480
errorNotification: !1

dist/scripts/templates.js

-3
Original file line numberDiff line numberDiff line change
@@ -3350,10 +3350,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
33503350
"<div ng-if=\"showRouterHostnameAlert(ingress, admittedCondition)\" class=\"mar-top-lg\">\n" +
33513351
"<div class=\"alert alert-info\">\n" +
33523352
"<span class=\"pficon pficon-info\" aria-hidden=\"true\"></span>\n" +
3353-
"<span class=\"mar-right-sm\">\n" +
33543353
"The DNS admin should set up a CNAME from the route's hostname, {{ingress.host}}, to the router's canonical hostname, {{ingress.routerCanonicalHostname}}.\n" +
3355-
"</span>\n" +
3356-
"<a href=\"\" ng-click=\"hideRouterHostnameAlert(ingress)\" role=\"button\" class=\"nowrap\">Don't Show Me Again</a>\n" +
33573354
"</div>\n" +
33583355
"</div>\n" +
33593356
"</div>\n" +

0 commit comments

Comments
 (0)