Skip to content

Commit 8af5164

Browse files
author
OpenShift Bot
authored
Merge pull request #2211 from cdcabrera/issue-envfrom-copy
Merged by openshift-bot
2 parents 5017f92 + a0b1615 commit 8af5164

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

app/views/directives/edit-environment-variables.html

+4-5
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
<div ng-repeat="container in $ctrl.containers">
44
<h3>Container {{container.name}}</h3>
55

6-
<h4 class="section-label">Variables</h4>
76
<div ng-if="!$ctrl.canIUpdate || $ctrl.ngReadonly">
87
<span ng-if="!container.env.length">
98
No environment variables set in the {{$ctrl.apiObject.kind | humanizeKind}}
@@ -30,8 +29,8 @@ <h4 class="section-label">Variables</h4>
3029
key-validator="[A-Za-z_][A-Za-z0-9_]*"
3130
key-validator-error="Please enter a valid key."
3231
key-validator-error-tooltip="A valid environment variable name is an alphanumeric (a-z and 0-9) string beginning with a letter that may contain underscores."
33-
add-row-link="Add Variable"
34-
add-row-with-selectors-link="Add Variable from Config Map or Secret"
32+
add-row-link="Add Value"
33+
add-row-with-selectors-link="Add Value from Config Map or Secret"
3534
show-header>
3635
</key-value-editor>
3736

@@ -44,9 +43,9 @@ <h4 class="section-label">
4443
</h4>
4544
<edit-environment-from
4645
entries="container.envFrom"
47-
selector-placeholder="Secret/Config Map"
46+
selector-placeholder="Config Map/Secret"
4847
env-from-selector-options="$ctrl.valueFromObjects"
49-
add-row-link="Add ALL Values from Secret or Config Map"
48+
add-row-link="Add ALL Values from Config Map or Secret"
5049
show-header>
5150
</edit-environment-from>
5251
</div>

dist/scripts/templates.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -6655,21 +6655,20 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
66556655
"<confirm-on-exit ng-if=\"$ctrl.canIUpdate && !$ctrl.ngReadonly\" dirty=\"$ctrl.form.$dirty\"></confirm-on-exit>\n" +
66566656
"<div ng-repeat=\"container in $ctrl.containers\">\n" +
66576657
"<h3>Container {{container.name}}</h3>\n" +
6658-
"<h4 class=\"section-label\">Variables</h4>\n" +
66596658
"<div ng-if=\"!$ctrl.canIUpdate || $ctrl.ngReadonly\">\n" +
66606659
"<span ng-if=\"!container.env.length\">\n" +
66616660
"No environment variables set in the {{$ctrl.apiObject.kind | humanizeKind}} template for container {{container.name}}.\n" +
66626661
"</span>\n" +
66636662
"<key-value-editor ng-if=\"container.env.length\" entries=\"container.env\" key-placeholder=\"Name\" value-placeholder=\"Value\" cannot-add cannot-sort cannot-delete is-readonly show-header>\n" +
66646663
"</key-value-editor>\n" +
66656664
"</div>\n" +
6666-
"<key-value-editor ng-if=\"$ctrl.canIUpdate && !$ctrl.ngReadonly\" entries=\"container.env\" key-placeholder=\"Name\" value-placeholder=\"Value\" value-from-selector-options=\"$ctrl.valueFromObjects\" key-validator=\"[A-Za-z_][A-Za-z0-9_]*\" key-validator-error=\"Please enter a valid key.\" key-validator-error-tooltip=\"A valid environment variable name is an alphanumeric (a-z and 0-9) string beginning with a letter that may contain underscores.\" add-row-link=\"Add Variable\" add-row-with-selectors-link=\"Add Variable from Config Map or Secret\" show-header>\n" +
6665+
"<key-value-editor ng-if=\"$ctrl.canIUpdate && !$ctrl.ngReadonly\" entries=\"container.env\" key-placeholder=\"Name\" value-placeholder=\"Value\" value-from-selector-options=\"$ctrl.valueFromObjects\" key-validator=\"[A-Za-z_][A-Za-z0-9_]*\" key-validator-error=\"Please enter a valid key.\" key-validator-error-tooltip=\"A valid environment variable name is an alphanumeric (a-z and 0-9) string beginning with a letter that may contain underscores.\" add-row-link=\"Add Value\" add-row-with-selectors-link=\"Add Value from Config Map or Secret\" show-header>\n" +
66676666
"</key-value-editor>\n" +
66686667
"<h4 class=\"section-label\">\n" +
66696668
"Environment From\n" +
66706669
"<span class=\"pficon pficon-help\" aria-hidden=\"true\" data-toggle=\"tooltip\" data-original-title=\"Environment From lets you add all key-value pairs from a config map or secret as environment variables.\"></span>\n" +
66716670
"</h4>\n" +
6672-
"<edit-environment-from entries=\"container.envFrom\" selector-placeholder=\"Secret/Config Map\" env-from-selector-options=\"$ctrl.valueFromObjects\" add-row-link=\"Add ALL Values from Secret or Config Map\" show-header>\n" +
6671+
"<edit-environment-from entries=\"container.envFrom\" selector-placeholder=\"Config Map/Secret\" env-from-selector-options=\"$ctrl.valueFromObjects\" add-row-link=\"Add ALL Values from Config Map or Secret\" show-header>\n" +
66736672
"</edit-environment-from>\n" +
66746673
"</div>\n" +
66756674
"<button class=\"btn btn-default\" ng-if=\"$ctrl.canIUpdate && !$ctrl.ngReadonly\" ng-click=\"$ctrl.save()\" ng-disabled=\"$ctrl.form.$pristine || $ctrl.form.$invalid\">Save</button>\n" +

0 commit comments

Comments
 (0)