Skip to content

Commit 8d9ea89

Browse files
committed
Make close notification link accessible
The link was missing an `href` and could not be triggered using the keyboard.
1 parent b4196ee commit 8d9ea89

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

app/views/directives/notifications/notification-body.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
ng-click="$ctrl.customScope.markRead(notification)">
55
<a
66
class="pull-right"
7-
tabindex="0"
7+
href=""
88
ng-click="$ctrl.customScope.clear(notification, $index, notificationGroup)">
99
<span class="sr-only">Clear notification</span>
1010
<span

dist/scripts/templates.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -7570,7 +7570,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
75707570

75717571
$templateCache.put('views/directives/notifications/notification-body.html',
75727572
"<div class=\"drawer-pf-notification-inner\" tabindex=\"0\" ng-click=\"$ctrl.customScope.markRead(notification)\">\n" +
7573-
"<a class=\"pull-right\" tabindex=\"0\" ng-click=\"$ctrl.customScope.clear(notification, $index, notificationGroup)\">\n" +
7573+
"<a class=\"pull-right\" href=\"\" ng-click=\"$ctrl.customScope.clear(notification, $index, notificationGroup)\">\n" +
75747574
"<span class=\"sr-only\">Clear notification</span>\n" +
75757575
"<span ng-if=\"notification.event\" aria-hidden=\"true\" class=\"pull-left pficon pficon-close\"></span>\n" +
75767576
"</a>\n" +

0 commit comments

Comments
 (0)