Skip to content

Commit 906026b

Browse files
committed
Don't show in-page alerts for create project
Fixes an issue where both an in-page alert and toast notification can appear when there is an error creating a project.
1 parent da50b08 commit 906026b

File tree

4 files changed

+3
-4
lines changed

4 files changed

+3
-4
lines changed

app/scripts/controllers/createProject.js

-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ angular.module('openshiftConsole')
1616
Constants) {
1717
var landingPageEnabled = _.get(Constants, 'ENABLE_TECH_PREVIEW_FEATURE.service_catalog_landing_page');
1818

19-
$scope.alerts = {};
2019
$scope.onProjectCreated = function(encodedProjectName) {
2120
if (landingPageEnabled) {
2221
// If the new experience is enabled, return to project list.

app/views/create-project.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<div class="container surface-shaded gutter-top">
1212
<div class="col-md-12">
1313
<h1>Create Project</h1>
14-
<alerts alerts="alerts"></alerts>
14+
<alerts alerts="{}"></alerts>
1515
<create-project alerts="alerts" redirect-action="onProjectCreated"></create-project>
1616
</div>
1717
</div>

dist/scripts/scripts.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -8131,7 +8131,7 @@ a.canCreateProject = !1;
81318131
});
81328132
} ]), angular.module("openshiftConsole").controller("CreateProjectController", [ "$scope", "$location", "$window", "AuthService", "Constants", function(a, b, c, d, e) {
81338133
var f = _.get(e, "ENABLE_TECH_PREVIEW_FEATURE.service_catalog_landing_page");
8134-
a.alerts = {}, a.onProjectCreated = function(a) {
8134+
a.onProjectCreated = function(a) {
81358135
f ? c.history.back() :b.path("project/" + a + "/create");
81368136
}, d.withUser();
81378137
} ]), angular.module("openshiftConsole").controller("EditProjectController", [ "$scope", "$routeParams", "$filter", "$location", "DataService", "ProjectsService", "Navigate", function(a, b, c, d, e, f, g) {

dist/scripts/templates.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -4678,7 +4678,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
46784678
"<div class=\"container surface-shaded gutter-top\">\n" +
46794679
"<div class=\"col-md-12\">\n" +
46804680
"<h1>Create Project</h1>\n" +
4681-
"<alerts alerts=\"alerts\"></alerts>\n" +
4681+
"<alerts alerts=\"{}\"></alerts>\n" +
46824682
"<create-project alerts=\"alerts\" redirect-action=\"onProjectCreated\"></create-project>\n" +
46834683
"</div>\n" +
46844684
"</div>\n" +

0 commit comments

Comments
 (0)