Skip to content

Commit 9466db7

Browse files
committed
Add build failure reasons to monitoring and overview pages
1 parent d264ce4 commit 9466db7

File tree

3 files changed

+12
-4
lines changed

3 files changed

+12
-4
lines changed

app/views/_triggers.html

+3-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,9 @@
1919
</div>
2020
<div class="build-phase">
2121
<status-icon status="build.status.phase"></status-icon>
22-
{{build.status.phase}}<span ng-if="(build | isIncompleteBuild) && trigger.imageChangeParams.automatic">. A new deployment will be created automatically once the build completes.</span>
22+
<span ng-if="!build.status.message || build.status.phase === 'Cancelled'">{{build.status.phase}}.</span>
23+
<span ng-if="build.status.message && build.status.phase !== 'Cancelled'">{{build.status.message}}.</span>
24+
<span ng-if="(build | isIncompleteBuild) && trigger.imageChangeParams.automatic">A new deployment will be created automatically once the build completes.</span>
2325
</div>
2426
<span am-time-ago="build.metadata.creationTimestamp" class="build-timestamp"></span>
2527
<div ng-if="'builds/log' | canI : 'get'" class="build-links">

app/views/monitoring.html

+3-1
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,9 @@ <h2>Builds</h2>
303303
<small>created <span am-time-ago="build.metadata.creationTimestamp"></span></small>
304304
</div>
305305
<div class="list-group-item-text">
306-
<build-status build="build"></build-status>
306+
<status-icon status="build.status.phase" disable-animation fixed-width="true"></status-icon>
307+
<span ng-if="build.status.phase ==='Failed'">{{(build.status.reason || build.status.phase) | sentenceCase}}</span>
308+
<span ng-if="build.status.phase !== 'Failed'">{{build.status.phase | sentenceCase}}</span>
307309
</div>
308310
</div>
309311
<div class="list-view-pf-additional-info">

dist/scripts/templates.js

+6-2
Original file line numberDiff line numberDiff line change
@@ -745,7 +745,9 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
745745
"</div>\n" +
746746
"<div class=\"build-phase\">\n" +
747747
"<status-icon status=\"build.status.phase\"></status-icon>\n" +
748-
"{{build.status.phase}}<span ng-if=\"(build | isIncompleteBuild) && trigger.imageChangeParams.automatic\">. A new deployment will be created automatically once the build completes.</span>\n" +
748+
"<span ng-if=\"!build.status.message || build.status.phase === 'Cancelled'\">{{build.status.phase}}.</span>\n" +
749+
"<span ng-if=\"build.status.message && build.status.phase !== 'Cancelled'\">{{build.status.message}}.</span>\n" +
750+
"<span ng-if=\"(build | isIncompleteBuild) && trigger.imageChangeParams.automatic\">A new deployment will be created automatically once the build completes.</span>\n" +
749751
"</div>\n" +
750752
"<span am-time-ago=\"build.metadata.creationTimestamp\" class=\"build-timestamp\"></span>\n" +
751753
"<div ng-if=\"'builds/log' | canI : 'get'\" class=\"build-links\">\n" +
@@ -9845,7 +9847,9 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
98459847
"<small>created <span am-time-ago=\"build.metadata.creationTimestamp\"></span></small>\n" +
98469848
"</div>\n" +
98479849
"<div class=\"list-group-item-text\">\n" +
9848-
"<build-status build=\"build\"></build-status>\n" +
9850+
"<status-icon status=\"build.status.phase\" disable-animation fixed-width=\"true\"></status-icon>\n" +
9851+
"<span ng-if=\"build.status.phase ==='Failed'\">{{(build.status.reason || build.status.phase) | sentenceCase}}</span>\n" +
9852+
"<span ng-if=\"build.status.phase !== 'Failed'\">{{build.status.phase | sentenceCase}}</span>\n" +
98499853
"</div>\n" +
98509854
"</div>\n" +
98519855
"<div class=\"list-view-pf-additional-info\">\n" +

0 commit comments

Comments
 (0)