Skip to content

Commit 9b48a7b

Browse files
Merge pull request #2403 from benjaminapetersen/issue/1942/navigate-filter-error
Automatic merge from submit-queue. Low risk fix for issue 1942: keep build breadcrumbs from throwing error Partial fix for issue #1942. See the issue for details. Per conversation on irc. @jwforres @spadgett
2 parents 2e5d697 + 779ef29 commit 9b48a7b

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

app/scripts/controllers/build.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,10 @@ angular.module('openshiftConsole')
107107

108108
var buildNumber = annotation(build, "buildNumber");
109109
if (buildNumber) {
110-
$scope.breadcrumbs[2].title = "#" + buildNumber;
110+
// tmp fix for issue #1942
111+
if($scope.breadcrumbs[2]) {
112+
$scope.breadcrumbs[2].title = "#" + buildNumber;
113+
}
111114
}
112115
if (action === "DELETED") {
113116
$scope.alerts["deleted"] = {

dist/scripts/scripts.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5529,7 +5529,7 @@ e.eventObjects = l ? [ e.build, l ] : [ e.build ];
55295529
}, f = function(t, n) {
55305530
e.loaded = !0, e.build = t, m(t), c();
55315531
var a = u(t, "buildNumber");
5532-
a && (e.breadcrumbs[2].title = "#" + a), "DELETED" === n && (e.alerts.deleted = {
5532+
a && e.breadcrumbs[2] && (e.breadcrumbs[2].title = "#" + a), "DELETED" === n && (e.alerts.deleted = {
55335533
type: "warning",
55345534
message: "This build has been deleted."
55355535
});

0 commit comments

Comments
 (0)