Skip to content

Commit a6bf807

Browse files
author
OpenShift Bot
authored
Merge pull request #2017 from spadgett/mobile-hamburger-fix
Merged by openshift-bot
2 parents becea5e + c5a33e4 commit a6bf807

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

app/styles/_vertical-nav.less

+3-1
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,13 @@
88
transition: width .1s ease-in-out, left .1s ease-in-out;
99
z-index: 990;
1010
@media(min-width: @screen-sm-min) {
11-
top: @navbar-os-header-height-desktop;
11+
// Hide at wider screen widths unless there is a project.
12+
display: none;
1213
}
1314
.has-project-bar & {
1415
top: (@navbar-os-header-height-mobile + @project-bar-height-mobile);
1516
@media(min-width: @screen-sm-min) {
17+
display: block;
1618
top: (@navbar-os-header-height-desktop + @project-bar-height-desktop);
1719
}
1820
}

app/views/_sidebar.html

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
<div
2-
ng-if="view.hasProject"
32
class="nav-pf-vertical nav-pf-vertical-with-sub-menus"
43
ng-class="{
54
collapsed: nav.collapsed && !isMobile,
@@ -9,7 +8,7 @@
98
'show-mobile-secondary': nav.showMobileNav && sidebar.showMobileSecondary && isMobile
109
}"
1110
on-esc="closeNav()">
12-
<nav class="nav-vertical-primary">
11+
<nav ng-if="view.hasProject" class="nav-vertical-primary">
1312
<ul class="list-group">
1413

1514
<!-- Primary Nav -->

dist/scripts/templates.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -458,14 +458,14 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
458458

459459

460460
$templateCache.put('views/_sidebar.html',
461-
"<div ng-if=\"view.hasProject\" class=\"nav-pf-vertical nav-pf-vertical-with-sub-menus\" ng-class=\"{\n" +
461+
"<div class=\"nav-pf-vertical nav-pf-vertical-with-sub-menus\" ng-class=\"{\n" +
462462
" collapsed: nav.collapsed && !isMobile,\n" +
463463
" 'hide-mobile-nav': !nav.showMobileNav && isMobile,\n" +
464464
" 'hover-secondary-nav-pf': sidebar.secondaryOpen && !isMobile,\n" +
465465
" 'show-mobile-nav': nav.showMobileNav && isMobile,\n" +
466466
" 'show-mobile-secondary': nav.showMobileNav && sidebar.showMobileSecondary && isMobile\n" +
467467
" }\" on-esc=\"closeNav()\">\n" +
468-
"<nav class=\"nav-vertical-primary\">\n" +
468+
"<nav ng-if=\"view.hasProject\" class=\"nav-vertical-primary\">\n" +
469469
"<ul class=\"list-group\">\n" +
470470
"\n" +
471471
"<li ng-repeat=\"primaryItem in navItems\" ng-class=\"{\n" +

dist/styles/main.css

+2-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)