Skip to content

Commit a745b40

Browse files
rhamiltorhamilto
committed
Removing table-hover from tables to address inconsistency in hover color
Fixes #1904 Until patternfly/patternfly-design#314 is addressed, I think we should avoid using .table-hover in our tables.
1 parent 5709d8a commit a745b40

17 files changed

+45
-77
lines changed

‎app/views/browse/build-config.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ <h2>No builds.</h2>
178178
</div>
179179
</div>
180180
</div>
181-
<table ng-if="!(buildConfig | isJenkinsPipelineStrategy)" class="table table-bordered table-hover table-mobile">
181+
<table ng-if="!(buildConfig | isJenkinsPipelineStrategy)" class="table table-bordered table-mobile">
182182
<thead>
183183
<tr>
184184
<th>Build</th>
@@ -220,7 +220,7 @@ <h2>No builds.</h2>
220220
</table>
221221
<div ng-if="buildConfig | isJenkinsPipelineStrategy">
222222
<build-pipeline build="build" ng-repeat="build in orderedBuilds track by (build | uid)"></build-pipeline>
223-
<table ng-if="(builds | hashSize) === 0" class="table table-bordered table-hover table-mobile">
223+
<table ng-if="(builds | hashSize) === 0" class="table table-bordered table-mobile">
224224
<tbody><tr><td><em>{{emptyMessage}}</em></td></tr></tbody>
225225
</table>
226226
</div>

‎app/views/browse/config-maps.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ <h1>
2828
<div class="col-md-12">
2929
<div ng-if="!loaded">Loading...</div>
3030
<div ng-if="loaded">
31-
<table class="table table-bordered table-hover table-mobile table-layout-fixed">
31+
<table class="table table-bordered table-mobile table-layout-fixed">
3232
<colgroup>
3333
<col class="col-sm-5">
3434
</colgroup>

‎app/views/browse/deployment-config.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ <h1 class="contains-actions">
129129
</div>
130130
</div>
131131
</div>
132-
<table class="table table-bordered table-hover table-mobile">
132+
<table class="table table-bordered table-mobile">
133133
<thead>
134134
<tr>
135135
<th>Deployment</th>

‎app/views/browse/deployment.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ <h1 class="contains-actions">
9090
</div>
9191
</div>
9292
</div>
93-
<table class="table table-bordered table-hover table-mobile table-layout-fixed">
93+
<table class="table table-bordered table-mobile table-layout-fixed">
9494
<colgroup>
9595
<col class="col-sm-2">
9696
<col class="col-sm-4">

‎app/views/browse/routes.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ <h1>
2626
<alerts alerts="alerts"></alerts>
2727
<div class="row">
2828
<div class="col-md-12">
29-
<table class="table table-bordered table-hover table-mobile table-layout-fixed">
29+
<table class="table table-bordered table-mobile table-layout-fixed">
3030
<colgroup>
3131
<col class="col-sm-3">
3232
<col class="col-sm-3">

‎app/views/browse/stateful-sets.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ <h1>
2828
<div ng-if="!loaded">Loading...</div>
2929
<div class="row" ng-if="loaded">
3030
<div class="col-md-12">
31-
<table class="table table-bordered table-hover table-mobile table-layout-fixed">
31+
<table class="table table-bordered table-mobile table-layout-fixed">
3232
<colgroup>
3333
<col class="col-sm-5">
3434
</colgroup>

‎app/views/builds.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ <h1>
2323
<alerts alerts="alerts"></alerts>
2424
<div class="row">
2525
<div class="col-md-12">
26-
<table class="table table-bordered table-hover table-mobile table-layout-fixed">
26+
<table class="table table-bordered table-mobile table-layout-fixed">
2727
<colgroup>
2828
<col class="col-sm-2">
2929
<col class="col-sm-1">

‎app/views/deployments.html

+4-4
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ <h1>
2424
<div class="row">
2525
<div class="col-md-12">
2626
<h3 ng-if="(deployments | size) || (replicaSets | size)">Deployment Configurations</h3>
27-
<table class="table table-bordered table-hover table-mobile table-layout-fixed">
27+
<table class="table table-bordered table-mobile table-layout-fixed">
2828
<colgroup>
2929
<col class="col-sm-3">
3030
<col class="col-sm-2">
@@ -110,7 +110,7 @@ <h3 ng-if="(deployments | size) || (replicaSets | size)">Deployment Configuratio
110110
</table>
111111
<div ng-if="deployments | size">
112112
<h3>Deployments</h3>
113-
<table class="table table-bordered table-hover table-mobile table-layout-fixed">
113+
<table class="table table-bordered table-mobile table-layout-fixed">
114114
<colgroup>
115115
<col class="col-sm-4">
116116
<col class="col-sm-2">
@@ -155,7 +155,7 @@ <h3>Deployments</h3>
155155
</div>
156156
<div ng-if="replicaSets | hashSize" id="replica-sets">
157157
<h3>Replica Sets</h3>
158-
<table class="table table-bordered table-hover table-mobile table-layout-fixed">
158+
<table class="table table-bordered table-mobile table-layout-fixed">
159159
<colgroup>
160160
<col class="col-sm-4">
161161
</colgroup>
@@ -183,7 +183,7 @@ <h3>Replica Sets</h3>
183183
</div>
184184
<div ng-if="(unfilteredReplicationControllers | hashSize) > 0" id="replica-controllers">
185185
<h3>Other Replication Controllers</h3>
186-
<table class="table table-bordered table-hover table-mobile table-layout-fixed">
186+
<table class="table table-bordered table-mobile table-layout-fixed">
187187
<colgroup>
188188
<col class="col-sm-5">
189189
</colgroup>

‎app/views/directives/events.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
</div>
3535
</div>
3636
</div>
37-
<table class="table table-bordered table-condensed table-mobile table-hover table-layout-fixed events-table">
37+
<table class="table table-bordered table-condensed table-layout-fixed events-table">
3838
<thead>
3939
<tr>
4040
<th id="time">Time</th>

‎app/views/directives/pods-table.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<table class="table table-bordered table-hover table-mobile table-layout-fixed">
1+
<table class="table table-bordered table-mobile table-layout-fixed">
22
<colgroup>
33
<col class="col-sm-4">
44
<col class="col-sm-3">

‎app/views/directives/traffic-table.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<!-- Table combining routes and ports for a service -->
2-
<table class="table table-bordered table-hover table-mobile">
2+
<table class="table table-bordered table-mobile">
33
<thead>
44
<tr>
55
<th>{{customNameHeader || 'Route'}}<span ng-if="showNodePorts"> / Node Port</span></th>

‎app/views/images.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ <h1>
2323
<alerts alerts="alerts"></alerts>
2424
<div class="row">
2525
<div class="col-md-12">
26-
<table class="table table-bordered table-hover table-mobile table-layout-fixed">
26+
<table class="table table-bordered table-mobile table-layout-fixed">
2727
<colgroup>
2828
<col class="col-sm-3">
2929
<col class="col-sm-5">

‎app/views/secrets.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ <h1>
2222
<div ng-if="!loaded" class="mar-top-xl">Loading...</div>
2323
<div ng-if="loaded" class="row">
2424
<div class="col-md-12">
25-
<table class="table table-bordered table-hover table-mobile secrets-table table-layout-fixed">
25+
<table class="table table-bordered table-mobile secrets-table table-layout-fixed">
2626
<colgroup>
2727
<col class="col-sm-5">
2828
<col class="col-sm-5">

‎app/views/services.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ <h1>
2323
<alerts alerts="alerts"></alerts>
2424
<div class="row">
2525
<div class="col-md-12">
26-
<table class="table table-bordered table-hover table-mobile table-layout-fixed">
26+
<table class="table table-bordered table-mobile table-layout-fixed">
2727
<colgroup>
2828
<col class="col-sm-3">
2929
</colgroup>

‎app/views/storage.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ <h2>Persistent Volume Claims</h2>
3434
<a ng-if="outOfClaims" href="" class="btn btn-default disabled" aria-disabled="true">Create Storage</a>
3535
</div>
3636
</div>
37-
<table class="table table-bordered table-hover table-mobile table-layout-fixed" ng-class="{ 'table-empty': (pvcs | hashSize) === 0 }">
37+
<table class="table table-bordered table-mobile table-layout-fixed" ng-class="{ 'table-empty': (pvcs | hashSize) === 0 }">
3838
<colgroup>
3939
<col class="col-sm-5">
4040
</colgroup>

‎dist/scripts/templates.js

+19-19
Original file line numberDiff line numberDiff line change
@@ -1743,7 +1743,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
17431743
"</div>\n" +
17441744
"</div>\n" +
17451745
"</div>\n" +
1746-
"<table ng-if=\"!(buildConfig | isJenkinsPipelineStrategy)\" class=\"table table-bordered table-hover table-mobile\">\n" +
1746+
"<table ng-if=\"!(buildConfig | isJenkinsPipelineStrategy)\" class=\"table table-bordered table-mobile\">\n" +
17471747
"<thead>\n" +
17481748
"<tr>\n" +
17491749
"<th>Build</th>\n" +
@@ -1785,7 +1785,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
17851785
"</table>\n" +
17861786
"<div ng-if=\"buildConfig | isJenkinsPipelineStrategy\">\n" +
17871787
"<build-pipeline build=\"build\" ng-repeat=\"build in orderedBuilds track by (build | uid)\"></build-pipeline>\n" +
1788-
"<table ng-if=\"(builds | hashSize) === 0\" class=\"table table-bordered table-hover table-mobile\">\n" +
1788+
"<table ng-if=\"(builds | hashSize) === 0\" class=\"table table-bordered table-mobile\">\n" +
17891789
"<tbody><tr><td><em>{{emptyMessage}}</em></td></tr></tbody>\n" +
17901790
"</table>\n" +
17911791
"</div>\n" +
@@ -2231,7 +2231,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
22312231
"<div class=\"col-md-12\">\n" +
22322232
"<div ng-if=\"!loaded\">Loading...</div>\n" +
22332233
"<div ng-if=\"loaded\">\n" +
2234-
"<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
2234+
"<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
22352235
"<colgroup>\n" +
22362236
"<col class=\"col-sm-5\">\n" +
22372237
"</colgroup>\n" +
@@ -2378,7 +2378,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
23782378
"</div>\n" +
23792379
"</div>\n" +
23802380
"</div>\n" +
2381-
"<table class=\"table table-bordered table-hover table-mobile\">\n" +
2381+
"<table class=\"table table-bordered table-mobile\">\n" +
23822382
"<thead>\n" +
23832383
"<tr>\n" +
23842384
"<th>Deployment</th>\n" +
@@ -2656,7 +2656,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
26562656
"</div>\n" +
26572657
"</div>\n" +
26582658
"</div>\n" +
2659-
"<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
2659+
"<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
26602660
"<colgroup>\n" +
26612661
"<col class=\"col-sm-2\">\n" +
26622662
"<col class=\"col-sm-4\">\n" +
@@ -3483,7 +3483,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
34833483
"<alerts alerts=\"alerts\"></alerts>\n" +
34843484
"<div class=\"row\">\n" +
34853485
"<div class=\"col-md-12\">\n" +
3486-
"<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
3486+
"<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
34873487
"<colgroup>\n" +
34883488
"<col class=\"col-sm-3\">\n" +
34893489
"<col class=\"col-sm-3\">\n" +
@@ -3878,7 +3878,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
38783878
"<div ng-if=\"!loaded\">Loading...</div>\n" +
38793879
"<div class=\"row\" ng-if=\"loaded\">\n" +
38803880
"<div class=\"col-md-12\">\n" +
3881-
"<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
3881+
"<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
38823882
"<colgroup>\n" +
38833883
"<col class=\"col-sm-5\">\n" +
38843884
"</colgroup>\n" +
@@ -3943,7 +3943,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
39433943
"<alerts alerts=\"alerts\"></alerts>\n" +
39443944
"<div class=\"row\">\n" +
39453945
"<div class=\"col-md-12\">\n" +
3946-
"<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
3946+
"<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
39473947
"<colgroup>\n" +
39483948
"<col class=\"col-sm-2\">\n" +
39493949
"<col class=\"col-sm-1\">\n" +
@@ -4954,7 +4954,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
49544954
"<div class=\"row\">\n" +
49554955
"<div class=\"col-md-12\">\n" +
49564956
"<h3 ng-if=\"(deployments | size) || (replicaSets | size)\">Deployment Configurations</h3>\n" +
4957-
"<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
4957+
"<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
49584958
"<colgroup>\n" +
49594959
"<col class=\"col-sm-3\">\n" +
49604960
"<col class=\"col-sm-2\">\n" +
@@ -5040,7 +5040,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
50405040
"</table>\n" +
50415041
"<div ng-if=\"deployments | size\">\n" +
50425042
"<h3>Deployments</h3>\n" +
5043-
"<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
5043+
"<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
50445044
"<colgroup>\n" +
50455045
"<col class=\"col-sm-4\">\n" +
50465046
"<col class=\"col-sm-2\">\n" +
@@ -5085,7 +5085,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
50855085
"</div>\n" +
50865086
"<div ng-if=\"replicaSets | hashSize\" id=\"replica-sets\">\n" +
50875087
"<h3>Replica Sets</h3>\n" +
5088-
"<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
5088+
"<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
50895089
"<colgroup>\n" +
50905090
"<col class=\"col-sm-4\">\n" +
50915091
"</colgroup>\n" +
@@ -5113,7 +5113,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
51135113
"</div>\n" +
51145114
"<div ng-if=\"(unfilteredReplicationControllers | hashSize) > 0\" id=\"replica-controllers\">\n" +
51155115
"<h3>Other Replication Controllers</h3>\n" +
5116-
"<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
5116+
"<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
51175117
"<colgroup>\n" +
51185118
"<col class=\"col-sm-5\">\n" +
51195119
"</colgroup>\n" +
@@ -6627,7 +6627,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
66276627
"</div>\n" +
66286628
"</div>\n" +
66296629
"</div>\n" +
6630-
"<table class=\"table table-bordered table-condensed table-mobile table-hover table-layout-fixed events-table\">\n" +
6630+
"<table class=\"table table-bordered table-condensed table-layout-fixed events-table\">\n" +
66316631
"<thead>\n" +
66326632
"<tr>\n" +
66336633
"<th id=\"time\">Time</th>\n" +
@@ -8512,7 +8512,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
85128512

85138513

85148514
$templateCache.put('views/directives/pods-table.html',
8515-
"<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
8515+
"<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
85168516
"<colgroup>\n" +
85178517
"<col class=\"col-sm-4\">\n" +
85188518
"<col class=\"col-sm-3\">\n" +
@@ -8764,7 +8764,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
87648764

87658765

87668766
$templateCache.put('views/directives/traffic-table.html',
8767-
" <table class=\"table table-bordered table-hover table-mobile\">\n" +
8767+
" <table class=\"table table-bordered table-mobile\">\n" +
87688768
"<thead>\n" +
87698769
"<tr>\n" +
87708770
"<th>{{customNameHeader || 'Route'}}<span ng-if=\"showNodePorts\"> / Node Port</span></th>\n" +
@@ -9978,7 +9978,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
99789978
"<alerts alerts=\"alerts\"></alerts>\n" +
99799979
"<div class=\"row\">\n" +
99809980
"<div class=\"col-md-12\">\n" +
9981-
"<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
9981+
"<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
99829982
"<colgroup>\n" +
99839983
"<col class=\"col-sm-3\">\n" +
99849984
"<col class=\"col-sm-5\">\n" +
@@ -12831,7 +12831,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
1283112831
"<div ng-if=\"!loaded\" class=\"mar-top-xl\">Loading...</div>\n" +
1283212832
"<div ng-if=\"loaded\" class=\"row\">\n" +
1283312833
"<div class=\"col-md-12\">\n" +
12834-
"<table class=\"table table-bordered table-hover table-mobile secrets-table table-layout-fixed\">\n" +
12834+
"<table class=\"table table-bordered table-mobile secrets-table table-layout-fixed\">\n" +
1283512835
"<colgroup>\n" +
1283612836
"<col class=\"col-sm-5\">\n" +
1283712837
"<col class=\"col-sm-5\">\n" +
@@ -12896,7 +12896,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
1289612896
"<alerts alerts=\"alerts\"></alerts>\n" +
1289712897
"<div class=\"row\">\n" +
1289812898
"<div class=\"col-md-12\">\n" +
12899-
"<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
12899+
"<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
1290012900
"<colgroup>\n" +
1290112901
"<col class=\"col-sm-3\">\n" +
1290212902
"</colgroup>\n" +
@@ -13030,7 +13030,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
1303013030
"<a ng-if=\"outOfClaims\" href=\"\" class=\"btn btn-default disabled\" aria-disabled=\"true\">Create Storage</a>\n" +
1303113031
"</div>\n" +
1303213032
"</div>\n" +
13033-
"<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\" ng-class=\"{ 'table-empty': (pvcs | hashSize) === 0 }\">\n" +
13033+
"<table class=\"table table-bordered table-mobile table-layout-fixed\" ng-class=\"{ 'table-empty': (pvcs | hashSize) === 0 }\">\n" +
1303413034
"<colgroup>\n" +
1303513035
"<col class=\"col-sm-5\">\n" +
1303613036
"</colgroup>\n" +

0 commit comments

Comments
 (0)