Skip to content

Commit ae6825c

Browse files
committed
Remove margin that causes errant spacing when build icon and message not shown
1 parent d4e91d8 commit ae6825c

File tree

5 files changed

+28
-13
lines changed

5 files changed

+28
-13
lines changed

app/styles/_overview.less

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,11 @@
2323
}
2424
}
2525
.builds-label {
26+
display: inline-block;
2627
margin-right: 5px;
28+
@media (max-width: @screen-sm-max) {
29+
margin-top: 5px;
30+
}
2731
}
2832
.mini-donut-link {
2933
color: @gray-darker;
@@ -54,7 +58,10 @@
5458
}
5559
.notification-icon-count {
5660
display: inline-block;
57-
margin: 0 5px 0 0;
61+
margin: 5px 5px 0 0;
62+
@media (min-width: @screen-md-min) {
63+
margin-top: 0;
64+
}
5865
[data-toggle="tooltip"] {
5966
cursor: help;
6067
}
@@ -227,6 +234,12 @@
227234
@media (min-width: @screen-sm-min) {
228235
justify-content: flex-end;
229236
}
237+
@media(max-width: @screen-xs-max) {
238+
&.deployment-in-progress-msg {
239+
margin-top: 5px;
240+
width: 100%;
241+
}
242+
}
230243
}
231244
.list-pf-expansion.in {
232245
.deployment-donut > div[row] {
@@ -427,11 +440,9 @@
427440
}
428441
}
429442
}
430-
.status-icons {
431-
margin-top: 5px;
432-
@media (min-width: @screen-md-min) {
443+
@media (min-width: @screen-md-min) {
444+
.status-icons {
433445
margin-right: 15px;
434-
margin-top: 0;
435446
width: 40%;
436447
}
437448
}

app/views/overview/_list-row-content.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ <h3>
3535
No deployments for <a ng-href="{{row.apiObject | navigateResourceURL}}">{{row.apiObject.metadata.name}}</a>
3636
</span>
3737
</div>
38-
<div ng-if="row.isDeploymentInProgress()" class="list-pf-details">
38+
<div ng-if="row.isDeploymentInProgress()" class="list-pf-details deployment-in-progress-msg">
3939
<div ng-if="row.apiObject.kind === 'DeploymentConfig'">
4040
<span class="mar-right-sm">
4141
<span class="hidden-xs">

dist/scripts/templates.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11768,7 +11768,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
1176811768
"No deployments for <a ng-href=\"{{row.apiObject | navigateResourceURL}}\">{{row.apiObject.metadata.name}}</a>\n" +
1176911769
"</span>\n" +
1177011770
"</div>\n" +
11771-
"<div ng-if=\"row.isDeploymentInProgress()\" class=\"list-pf-details\">\n" +
11771+
"<div ng-if=\"row.isDeploymentInProgress()\" class=\"list-pf-details deployment-in-progress-msg\">\n" +
1177211772
"<div ng-if=\"row.apiObject.kind === 'DeploymentConfig'\">\n" +
1177311773
"<span class=\"mar-right-sm\">\n" +
1177411774
"<span class=\"hidden-xs\">\n" +

dist/styles/main.css

Lines changed: 9 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/styles/vendor.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ kubernetes-container-terminal{position:relative;display:block}
178178
kubernetes-container-terminal .terminal{font-family:"Monospace Regular","DejaVu Sans Mono",Menlo,Monaco,Consolas,monospace;font-size:10px;color:#F0F0F0;text-align:left;outline:0;background-color:#000;border:1px solid #000;padding:10px;display:inline-block;line-height:1em}
179179
@media (min-width:568px){kubernetes-container-terminal .terminal{font-size:12px}
180180
}
181-
kubernetes-container-terminal .terminal-cursor{color:#000;background:#f0f0f0}
181+
kubernetes-container-terminal .terminal-cursor{background:#f0f0f0;color:#000;position:absolute}
182182
kubernetes-container-terminal .terminal-wrapper{display:inline-block;vertical-align:top}
183183
kubernetes-container-terminal .terminal-actions{display:inline-block;vertical-align:top;position:absolute;top:10px;right:34px;z-index:1}
184184
.spinner-white{border-bottom:4px solid rgba(255,255,255,.25)!important;border-left:4px solid rgba(255,255,255,.25)!important;border-right:4px solid rgba(255,255,255,.25)!important;border-top:4px solid rgba(255,255,255,.75)!important}

0 commit comments

Comments
 (0)