Skip to content

Commit b16134b

Browse files
author
OpenShift Bot
authored
Merge pull request #1970 from benjaminapetersen/bpeterse/hide-kve-on-build-if-no-envs
Merged by openshift-bot
2 parents f446b03 + 6c73175 commit b16134b

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

app/views/browse/build.html

+1
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,7 @@ <h3>Environment Variables</h3>
9999
Environment variables can be edited on the <a ng-href="{{build | configURLForResource}}?tab=environment">build configuration</a>.
100100
</p>
101101
<key-value-editor
102+
ng-if="(build | buildStrategy).env | size"
102103
entries="(build | buildStrategy).env"
103104
key-placeholder="Name"
104105
value-placeholder="Value"

dist/scripts/templates.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -2114,7 +2114,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
21142114
"<span class=\"pficon pficon-info\" aria-hidden=\"true\"></span>\n" +
21152115
"Environment variables can be edited on the <a ng-href=\"{{build | configURLForResource}}?tab=environment\">build configuration</a>.\n" +
21162116
"</p>\n" +
2117-
"<key-value-editor entries=\"(build | buildStrategy).env\" key-placeholder=\"Name\" value-placeholder=\"Value\" cannot-add cannot-delete cannot-sort is-readonly show-header class=\"mar-bottom-xl block\"></key-value-editor>\n" +
2117+
"<key-value-editor ng-if=\"(build | buildStrategy).env | size\" entries=\"(build | buildStrategy).env\" key-placeholder=\"Name\" value-placeholder=\"Value\" cannot-add cannot-delete cannot-sort is-readonly show-header class=\"mar-bottom-xl block\"></key-value-editor>\n" +
21182118
"<p ng-if=\"!(build | buildStrategy).env\"><em>The build strategy had no environment variables defined.</em></p>\n" +
21192119
"</uib-tab>\n" +
21202120
"<uib-tab active=\"selectedTab.logs\" ng-if=\"!(build | isJenkinsPipelineStrategy) && ('builds/log' | canI : 'get')\">\n" +

0 commit comments

Comments
 (0)