Skip to content

Commit b4af117

Browse files
Update addConfigVolume controller
1 parent c63e2f5 commit b4af117

File tree

4 files changed

+20
-17
lines changed

4 files changed

+20
-17
lines changed

app/scripts/controllers/addConfigVolume.js

+5-2
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,9 @@ angular.module('openshiftConsole')
6262
subpage: 'Add Config Files'
6363
});
6464

65+
$scope.configMapVersion = APIService.getPreferredVersion('configmaps');
66+
$scope.secretVersion = APIService.getPreferredVersion('secrets');
67+
6568
var humanizeKind = $filter('humanizeKind');
6669
$scope.groupByKind = function(object) {
6770
return humanizeKind(object.kind);
@@ -137,7 +140,7 @@ angular.module('openshiftConsole')
137140
}
138141
);
139142

140-
DataService.list("configmaps", context, null, { errorNotification: false }).then(function(configMapData) {
143+
DataService.list($scope.configMapVersion, context, null, { errorNotification: false }).then(function(configMapData) {
141144
$scope.configMaps = orderByDisplayName(configMapData.by("metadata.name"));
142145
}, function(e) {
143146
if (e.code === 403) {
@@ -148,7 +151,7 @@ angular.module('openshiftConsole')
148151
displayError('Could not load config maps', getErrorDetails(e));
149152
});
150153

151-
DataService.list("secrets", context, null, { errorNotification: false }).then(function(secretData) {
154+
DataService.list($scope.secretVersion, context, null, { errorNotification: false }).then(function(secretData) {
152155
$scope.secrets = orderByDisplayName(secretData.by("metadata.name"));
153156
}, function(e) {
154157
if (e.code === 403) {

app/views/add-config-volume.html

+6-6
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ <h2>The {{kind | humanizeKind}} could not be loaded.</h2>
1111
</div>
1212

1313
<div ng-if="targetObject && configMaps && secrets">
14-
<div ng-if="!configMaps.length && !secrets.length && !('configmaps' | canI : 'create') && !('secrets' | canI : 'create')" class="empty-state-message empty-state-full-page">
14+
<div ng-if="!configMaps.length && !secrets.length && !(configMapVersion | canI : 'create') && !(secretVersion | canI : 'create')" class="empty-state-message empty-state-full-page">
1515
<h2 class="text-center">No config maps or secrets.</h2>
1616

1717
<p class="gutter-top">
@@ -22,7 +22,7 @@ <h2 class="text-center">No config maps or secrets.</h2>
2222
<p ng-if="targetObject"><a ng-href="{{targetObject | navigateResourceURL}}">Back to {{kind | humanizeKind}} {{name}}</a></p>
2323
</div>
2424

25-
<div ng-if="configMaps.length || secrets.length || ('configmaps' | canI : 'create') || ('secrets' | canI : 'create')" class="mar-top-xl">
25+
<div ng-if="configMaps.length || secrets.length || (configMapVersion | canI : 'create') || (secretVersion | canI : 'create')" class="mar-top-xl">
2626
<h1>Add Config Files to {{name}}</h1>
2727
<div class="help-block">
2828
Add values from a config map or secret as volume. This will make the data available as files for {{kind | humanizeKind}} {{name}}.
@@ -44,12 +44,12 @@ <h1>Add Config Files to {{name}}</h1>
4444
<span ng-bind-html="source.metadata.name | highlight : $select.search"></span>
4545
</ui-select-choices>
4646
</ui-select>
47-
<div ng-if="('configmaps' | canI : 'create') || ('secrets' | canI : 'create')" class="mar-top-md">
48-
<span ng-if="'configmaps' | canI : 'create'">
47+
<div ng-if="(configMapVersion | canI : 'create') || (secretVersion | canI : 'create')" class="mar-top-md">
48+
<span ng-if="configMapVersion | canI : 'create'">
4949
<a ng-href="project/{{project.metadata.name}}/create-config-map">Create Config Map</a>
5050
</span>
51-
<span ng-if="'secrets' | canI : 'create'">
52-
<span ng-if="'configmaps' | canI : 'create'" class="action-divider" aria-hidden="true">|</span>
51+
<span ng-if="secretVersion | canI : 'create'">
52+
<span ng-if="configMapVersion | canI : 'create'" class="action-divider" aria-hidden="true">|</span>
5353
<a ng-href="project/{{project.metadata.name}}/create-secret">Create Secret</a>
5454
</span>
5555
</div>

dist/scripts/scripts.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -8466,7 +8466,7 @@ name: n.name,
84668466
kind: n.kind,
84678467
namespace: n.project,
84688468
subpage: "Add Config Files"
8469-
});
8469+
}), a.configMapVersion = o.getPreferredVersion("configmaps"), a.secretVersion = o.getPreferredVersion("secrets");
84708470
var h = e("humanizeKind");
84718471
a.groupByKind = function(e) {
84728472
return h(e.kind);
@@ -8507,13 +8507,13 @@ subpage: "Add Config Files"
85078507
});
85088508
}, function(e) {
85098509
a.error = e;
8510-
}), c.list("configmaps", r, null, {
8510+
}), c.list(a.configMapVersion, r, null, {
85118511
errorNotification: !1
85128512
}).then(function(e) {
85138513
a.configMaps = o(e.by("metadata.name"));
85148514
}, function(e) {
85158515
403 !== e.code ? b("Could not load config maps", d(e)) : a.configMaps = [];
8516-
}), c.list("secrets", r, null, {
8516+
}), c.list(a.secretVersion, r, null, {
85178517
errorNotification: !1
85188518
}).then(function(e) {
85198519
a.secrets = o(e.by("metadata.name"));

dist/scripts/templates.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -828,14 +828,14 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
828828
"<p>{{error | getErrorDetails}}</p>\n" +
829829
"</div>\n" +
830830
"<div ng-if=\"targetObject && configMaps && secrets\">\n" +
831-
"<div ng-if=\"!configMaps.length && !secrets.length && !('configmaps' | canI : 'create') && !('secrets' | canI : 'create')\" class=\"empty-state-message empty-state-full-page\">\n" +
831+
"<div ng-if=\"!configMaps.length && !secrets.length && !(configMapVersion | canI : 'create') && !(secretVersion | canI : 'create')\" class=\"empty-state-message empty-state-full-page\">\n" +
832832
"<h2 class=\"text-center\">No config maps or secrets.</h2>\n" +
833833
"<p class=\"gutter-top\">\n" +
834834
"There are no config maps or secrets in project {{project | displayName}} to use as a volume for this {{kind | humanizeKind}}.\n" +
835835
"</p>\n" +
836836
"<p ng-if=\"targetObject\"><a ng-href=\"{{targetObject | navigateResourceURL}}\">Back to {{kind | humanizeKind}} {{name}}</a></p>\n" +
837837
"</div>\n" +
838-
"<div ng-if=\"configMaps.length || secrets.length || ('configmaps' | canI : 'create') || ('secrets' | canI : 'create')\" class=\"mar-top-xl\">\n" +
838+
"<div ng-if=\"configMaps.length || secrets.length || (configMapVersion | canI : 'create') || (secretVersion | canI : 'create')\" class=\"mar-top-xl\">\n" +
839839
"<h1>Add Config Files to {{name}}</h1>\n" +
840840
"<div class=\"help-block\">\n" +
841841
"Add values from a config map or secret as volume. This will make the data available as files for {{kind | humanizeKind}} {{name}}.\n" +
@@ -855,12 +855,12 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
855855
"<span ng-bind-html=\"source.metadata.name | highlight : $select.search\"></span>\n" +
856856
"</ui-select-choices>\n" +
857857
"</ui-select>\n" +
858-
"<div ng-if=\"('configmaps' | canI : 'create') || ('secrets' | canI : 'create')\" class=\"mar-top-md\">\n" +
859-
"<span ng-if=\"'configmaps' | canI : 'create'\">\n" +
858+
"<div ng-if=\"(configMapVersion | canI : 'create') || (secretVersion | canI : 'create')\" class=\"mar-top-md\">\n" +
859+
"<span ng-if=\"configMapVersion | canI : 'create'\">\n" +
860860
"<a ng-href=\"project/{{project.metadata.name}}/create-config-map\">Create Config Map</a>\n" +
861861
"</span>\n" +
862-
"<span ng-if=\"'secrets' | canI : 'create'\">\n" +
863-
"<span ng-if=\"'configmaps' | canI : 'create'\" class=\"action-divider\" aria-hidden=\"true\">|</span>\n" +
862+
"<span ng-if=\"secretVersion | canI : 'create'\">\n" +
863+
"<span ng-if=\"configMapVersion | canI : 'create'\" class=\"action-divider\" aria-hidden=\"true\">|</span>\n" +
864864
"<a ng-href=\"project/{{project.metadata.name}}/create-secret\">Create Secret</a>\n" +
865865
"</span>\n" +
866866
"</div>\n" +

0 commit comments

Comments
 (0)