Skip to content

Commit c8051e9

Browse files
author
OpenShift Bot
authored
Merge pull request #1148 from benjaminapetersen/statefulsets-metrics-available
Merged by openshift-bot
2 parents f838067 + ffbca5b commit c8051e9

File tree

4 files changed

+25
-18
lines changed

4 files changed

+25
-18
lines changed

Diff for: app/scripts/controllers/statefulSet.js

+6-1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ angular
99
AlertMessageService,
1010
BreadcrumbsService,
1111
DataService,
12+
MetricsService,
1213
ProjectsService) {
1314

1415
$scope.projectName = $routeParams.project;
@@ -51,6 +52,10 @@ angular
5152
version: 'v1beta1'
5253
};
5354

55+
MetricsService.isAvailable().then(function(available) {
56+
$scope.metricsAvailable = available;
57+
});
58+
5459
ProjectsService
5560
.get($routeParams.project)
5661
.then(_.spread(function(project, context) {
@@ -59,7 +64,7 @@ angular
5964
DataService
6065
.get(resourceGroupVersion, $scope.statefulSetName, context)
6166
.then(function(statefulSet) {
62-
67+
6368
angular.extend($scope, {
6469
statefulSet: updateEnvVars(statefulSet),
6570
project: project,

Diff for: app/views/browse/stateful-set.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ <h3>Container {{container.name}} Environment Variables</h3>
162162
</div>
163163
</uib-tab>
164164

165-
<uib-tab active="selectedTab.metrics">
165+
<uib-tab ng-if="metricsAvailable" active="selectedTab.metrics">
166166
<uib-tab-heading>Metrics</uib-tab-heading>
167167
<div class="resource-metrics">
168168
<deployment-metrics

Diff for: dist/scripts/scripts.js

+17-15
Original file line numberDiff line numberDiff line change
@@ -6502,53 +6502,55 @@ statefulSets:b.by("metadata.name")
65026502
d.unwatchAll(f);
65036503
});
65046504
}));
6505-
} ]), angular.module("openshiftConsole").controller("StatefulSetController", [ "$filter", "$scope", "$routeParams", "AlertMessageService", "BreadcrumbsService", "DataService", "ProjectsService", function(a, b, c, d, e, f, g) {
6505+
} ]), angular.module("openshiftConsole").controller("StatefulSetController", [ "$filter", "$scope", "$routeParams", "AlertMessageService", "BreadcrumbsService", "DataService", "MetricsService", "ProjectsService", function(a, b, c, d, e, f, g, h) {
65066506
b.projectName = c.project, b.statefulSetName = c.statefulset, b.forms = {}, b.alerts = {}, b.breadcrumbs = e.getBreadcrumbs({
65076507
name:b.statefulSetName,
65086508
kind:"statefulSet",
65096509
namespace:c.project
65106510
}), b.emptyMessage = "Loading...";
6511-
var h = a("altTextForValueFrom"), i = function(a) {
6511+
var i = a("altTextForValueFrom"), j = function(a) {
65126512
return _.each(a.spec.template.spec.containers, function(a) {
6513-
_.each(a.env, h);
6513+
_.each(a.env, i);
65146514
}), a;
65156515
};
65166516
d.getAlerts().forEach(function(a) {
65176517
b.alerts[a.name] = a.data;
65186518
}), d.clearAlerts();
6519-
var j, k = [], l = function(a, b) {
6519+
var k, l = [], m = function(a, b) {
65206520
if (a && b) return b.select(a);
6521-
}, m = {
6521+
}, n = {
65226522
resource:"statefulsets",
65236523
group:"apps",
65246524
version:"v1beta1"
65256525
};
6526-
g.get(c.project).then(_.spread(function(a, c) {
6527-
j = c, f.get(m, b.statefulSetName, c).then(function(d) {
6526+
g.isAvailable().then(function(a) {
6527+
b.metricsAvailable = a;
6528+
}), h.get(c.project).then(_.spread(function(a, c) {
6529+
k = c, f.get(n, b.statefulSetName, c).then(function(d) {
65286530
angular.extend(b, {
6529-
statefulSet:i(d),
6531+
statefulSet:j(d),
65306532
project:a,
65316533
projectContext:c,
65326534
loaded:!0,
65336535
isScalable:function() {
65346536
return !1;
65356537
},
65366538
scale:function() {}
6537-
}), k.push(f.watchObject(m, b.statefulSetName, c, function(a) {
6539+
}), l.push(f.watchObject(n, b.statefulSetName, c, function(a) {
65386540
angular.extend(b, {
6539-
resourceGroupVersion:m,
6540-
statefulSet:i(a)
6541+
resourceGroupVersion:n,
6542+
statefulSet:j(a)
65416543
});
65426544
}));
65436545
var e, g;
65446546
b.$watch("statefulSet.spec.selector", function() {
6545-
g = new LabelSelector(b.statefulSet.spec.selector), b.podsForStatefulSet = l(e, g);
6546-
}, !0), k.push(f.watch("pods", c, function(a) {
6547-
e = a.by("metadata.name"), b.podsForStatefulSet = l(e, g);
6547+
g = new LabelSelector(b.statefulSet.spec.selector), b.podsForStatefulSet = m(e, g);
6548+
}, !0), l.push(f.watch("pods", c, function(a) {
6549+
e = a.by("metadata.name"), b.podsForStatefulSet = m(e, g);
65486550
}));
65496551
});
65506552
})), b.$on("$destroy", function() {
6551-
f.unwatchAll(k);
6553+
f.unwatchAll(l);
65526554
});
65536555
} ]), angular.module("openshiftConsole").controller("ServicesController", [ "$routeParams", "$scope", "AlertMessageService", "DataService", "ProjectsService", "$filter", "LabelFilter", "Logger", function(a, b, c, d, e, f, g, h) {
65546556
b.projectName = a.project, b.services = {}, b.unfilteredServices = {}, b.routesByService = {}, b.routes = {}, b.labelSuggestions = {}, b.alerts = b.alerts || {}, b.emptyMessage = "Loading...", b.emptyMessageRoutes = "Loading...", c.getAlerts().forEach(function(a) {

Diff for: dist/scripts/templates.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -4146,7 +4146,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
41464146
"</ng-form>\n" +
41474147
"</div>\n" +
41484148
"</uib-tab>\n" +
4149-
"<uib-tab active=\"selectedTab.metrics\">\n" +
4149+
"<uib-tab ng-if=\"metricsAvailable\" active=\"selectedTab.metrics\">\n" +
41504150
"<uib-tab-heading>Metrics</uib-tab-heading>\n" +
41514151
"<div class=\"resource-metrics\">\n" +
41524152
"<deployment-metrics ng-if=\"selectedTab.metrics && podsForStatefulSet\" pods=\"podsForStatefulSet\" containers=\"statefulSet.spec.template.spec.containers\" alerts=\"alerts\">\n" +

0 commit comments

Comments
 (0)