Skip to content

Commit cbaa42e

Browse files
Update to StatefulSet after 3.5 rebase, fix use of valueFrom for env vars on statefulSets
1 parent 17c258f commit cbaa42e

File tree

5 files changed

+190
-158
lines changed

5 files changed

+190
-158
lines changed

app/scripts/controllers/deployments.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,9 @@ angular.module('openshiftConsole')
6666
// TODO: keep petset/stateful set here or give it its own page?
6767
// I lean toward dedicated page.
6868
watches.push(DataService.watch({
69-
resource: 'petsets',
69+
resource: 'statefulsets',
7070
group: 'apps',
71-
version: 'v1alpha1'
71+
version: 'v1beta1'
7272
}, context, function(statefulSets) {
7373
$scope.statefulSets = statefulSets.by('metadata.name');
7474
}));

app/scripts/controllers/statefulSet.js

+12-4
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,14 @@ angular
2323
});
2424
$scope.emptyMessage = "Loading...";
2525

26+
var altTextForValueFrom = $filter('altTextForValueFrom');
27+
var updateEnvVars = function(statefulSet) {
28+
_.each(statefulSet.spec.template.spec.containers, function(container) {
29+
_.each(container.env, altTextForValueFrom);
30+
});
31+
return statefulSet;
32+
};
33+
2634
AlertMessageService.getAlerts().forEach(function(alert) {
2735
$scope.alerts[alert.name] = alert.data;
2836
});
@@ -39,9 +47,9 @@ angular
3947
};
4048

4149
var resourceGroupVersion = {
42-
resource: 'petsets',// TODO: statefulSets
50+
resource: 'statefulsets',
4351
group: 'apps',
44-
version: 'v1alpha1'
52+
version: 'v1beta1'
4553
};
4654

4755
ProjectsService
@@ -53,14 +61,14 @@ angular
5361
.get(resourceGroupVersion, $scope.statefulSetName, context)
5462
.then(function(statefulSet) {
5563
angular.extend($scope, {
56-
statefulSet: statefulSet,
64+
statefulSet: updateEnvVars(statefulSet),
5765
projectContext: context,
5866
loaded: true
5967
});
6068
watches.push(DataService.watchObject(resourceGroupVersion, $scope.statefulSetName, context, function(statefulSet) {
6169
angular.extend($scope, {
6270
resourceGroupVersion: resourceGroupVersion,
63-
statefulSet: statefulSet
71+
statefulSet: updateEnvVars(statefulSet)
6472
// TODO: support scaling
6573
// scale: function() {},
6674
// isScalable: function() { return true; }

app/scripts/filters/canI.js

-4
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,6 @@ angular
6565
'projects': [
6666
{group: '', resource: 'projects', verbs: ['delete', 'update']}
6767
],
68-
// todo: eliminate when we get the name change to statefulsets
69-
'petsets': [
70-
{group: 'apps', resource: 'petsets', verbs: ['update', 'delete']}
71-
],
7268
'statefulsets': [
7369
{group: 'apps', resource: 'statefulsets', verbs: ['update', 'delete']}
7470
]

dist/scripts/scripts.js

+44-34
Original file line numberDiff line numberDiff line change
@@ -362,9 +362,9 @@ reloadOnSearch:!1
362362
}).when("/project/:project/edit/dc/:deploymentconfig", {
363363
templateUrl:"views/edit/deployment-config.html",
364364
controller:"EditDeploymentConfigController"
365-
}).when("/project/:project/browse/petsets/:petset", {
366-
templateUrl:"views/browse/pet-set.html",
367-
controller:"PetSetController",
365+
}).when("/project/:project/browse/stateful-sets/:statefulset", {
366+
templateUrl:"views/browse/stateful-set.html",
367+
controller:"StatefulSetController",
368368
reloadOnSearch:!1
369369
}).when("/project/:project/browse/rs/:replicaSet", {
370370
templateUrl:"views/browse/replica-set.html",
@@ -2243,7 +2243,8 @@ i.segment("images").segmentCoded(h.substring(0, m)).segmentCoded(h.substring(m +
22432243
break;
22442244

22452245
case "PetSet":
2246-
i.segment("petsets").segmentCoded(h);
2246+
case "StatefulSet":
2247+
i.segment("stateful-sets").segmentCoded(h);
22472248
break;
22482249

22492250
case "PersistentVolumeClaim":
@@ -5844,11 +5845,11 @@ details:"The active filters are hiding all deployments."
58445845
}) :void delete a.alerts.deployments;
58455846
}
58465847
a.project = c, o.push(e.watch({
5847-
resource:"petsets",
5848+
resource:"statefulsets",
58485849
group:"apps",
5849-
version:"v1alpha1"
5850+
version:"v1beta1"
58505851
}, d, function(b) {
5851-
console.log("petsets?", b.by("metadata.name")), a.petsets = b.by("metadata.name");
5852+
a.statefulSets = b.by("metadata.name");
58525853
})), o.push(e.watch("replicationcontrollers", d, function(c, d, e) {
58535854
a.replicationControllers = c.by("metadata.name");
58545855
var j, k;
@@ -6421,39 +6422,48 @@ e.then(g);
64216422
g.unwatchAll(w);
64226423
});
64236424
}));
6424-
} ]), angular.module("openshiftConsole").controller("PetSetController", [ "$filter", "$scope", "$routeParams", "AlertMessageService", "BreadcrumbsService", "DataService", "ProjectsService", function(a, b, c, d, e, f, g) {
6425-
b.projectName = c.project, b.petSetName = c.petset, b.forms = {}, b.alerts = {}, b.breadcrumbs = e.getBreadcrumbs({
6426-
name:c.petset,
6427-
kind:"PetSet",
6425+
} ]), angular.module("openshiftConsole").controller("StatefulSetController", [ "$filter", "$scope", "$routeParams", "AlertMessageService", "BreadcrumbsService", "DataService", "ProjectsService", function(a, b, c, d, e, f, g) {
6426+
b.projectName = c.project, b.statefulSetName = c.statefulset, b.forms = {}, b.alerts = {}, b.breadcrumbs = e.getBreadcrumbs({
6427+
name:b.statefulSetName,
6428+
kind:"statefulSet",
64286429
namespace:c.project
6429-
}), b.emptyMessage = "Loading...", d.getAlerts().forEach(function(a) {
6430+
}), b.emptyMessage = "Loading...";
6431+
var h = a("altTextForValueFrom"), i = function(a) {
6432+
return _.each(a.spec.template.spec.containers, function(a) {
6433+
_.each(a.env, h);
6434+
}), a;
6435+
};
6436+
d.getAlerts().forEach(function(a) {
64306437
b.alerts[a.name] = a.data;
64316438
}), d.clearAlerts();
6432-
var h, i = [], j = function(a, b) {
6433-
if (a && b) return _.filter(a, function(a) {
6434-
return b.matches(a);
6435-
});
6436-
}, k = {
6437-
resource:"petsets",
6439+
var j, k = [], l = function(a, b) {
6440+
if (a && b) return b.select(a);
6441+
}, m = {
6442+
resource:"statefulsets",
64386443
group:"apps",
6439-
version:"v1alpha1"
6444+
version:"v1beta1"
64406445
};
6441-
g.get(c.project).then(_.spread(function(a, d) {
6442-
h = d, i.push(f.watchObject(k, c.petset, d, function(a) {
6446+
g.get(c.project).then(_.spread(function(a, c) {
6447+
j = c, f.get(m, b.statefulSetName, c).then(function(a) {
64436448
angular.extend(b, {
6444-
resourceGroupVersion:k,
6445-
petSet:a,
6449+
statefulSet:i(a),
6450+
projectContext:c,
64466451
loaded:!0
6447-
});
6448-
var c, e;
6449-
b.$watch("petSet.spec.selector", function() {
6450-
e = new LabelSelector(b.petSet.spec.selector), b.podsForPetSet = j(c, e);
6451-
}, !0), i.push(f.watch("pods", d, function(a) {
6452-
c = a.by("metadata.name"), b.podsForPetSet = j(c, e);
6452+
}), k.push(f.watchObject(m, b.statefulSetName, c, function(a) {
6453+
angular.extend(b, {
6454+
resourceGroupVersion:m,
6455+
statefulSet:i(a)
6456+
});
6457+
var d, e;
6458+
b.$watch("statefulSet.spec.selector", function() {
6459+
e = new LabelSelector(b.statefulSet.spec.selector), b.podsForStatefulSet = l(d, e);
6460+
}, !0), k.push(f.watch("pods", c, function(a) {
6461+
d = a.by("metadata.name"), b.podsForStatefulSet = l(d, e);
64536462
}));
64546463
}));
6464+
});
64556465
})), b.$on("$destroy", function() {
6456-
f.unwatchAll(i);
6466+
f.unwatchAll(k);
64576467
});
64586468
} ]), angular.module("openshiftConsole").controller("ServicesController", [ "$routeParams", "$scope", "AlertMessageService", "DataService", "ProjectsService", "$filter", "LabelFilter", "Logger", function(a, b, c, d, e, f, g, h) {
64596469
b.projectName = a.project, b.services = {}, b.unfilteredServices = {}, b.routesByService = {}, b.routes = {}, b.labelSuggestions = {}, b.alerts = b.alerts || {}, b.emptyMessage = "Loading...", b.emptyMessageRoutes = "Loading...", c.getAlerts().forEach(function(a) {
@@ -14211,14 +14221,14 @@ group:"",
1421114221
resource:"projects",
1421214222
verbs:[ "delete", "update" ]
1421314223
} ],
14214-
petsets:[ {
14224+
statefulsets:[ {
1421514225
group:"apps",
14216-
resource:"petsets",
14217-
verbs:[ "create", "update", "delete" ]
14226+
resource:"statefulsets",
14227+
verbs:[ "update", "delete" ]
1421814228
} ]
1421914229
};
1422014230
return function(c) {
14221-
return console.log("canIDoAny", c), _.some(b[c], function(b) {
14231+
return _.some(b[c], function(b) {
1422214232
return _.some(b.verbs, function(c) {
1422314233
return a({
1422414234
resource:b.resource,

0 commit comments

Comments
 (0)