Skip to content

Commit cdb8a24

Browse files
author
OpenShift Bot
authored
Merge pull request #1238 from sg00dwin/log-header-space-issue1233
Merged by openshift-bot
2 parents ee3fd10 + 65b81a8 commit cdb8a24

File tree

4 files changed

+14
-4
lines changed

4 files changed

+14
-4
lines changed

app/styles/_log.less

+8-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
}
44
.log-header {
55
margin-bottom: 3px;
6-
margin-top: @grid-gutter-width / 2;
76
label {
87
margin-bottom: 0;
98
}
@@ -50,6 +49,14 @@
5049
}
5150
}
5251
}
52+
.log-viewer-select {
53+
.log-header {
54+
margin-bottom: 8px;
55+
}
56+
.log-actions {
57+
margin-top: 5px;
58+
}
59+
}
5360
.log-size-warning {
5461
margin: 0;
5562
}

app/views/monitoring.html

+2-1
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,8 @@ <h2>Pods</h2>
116116
empty="logEmpty.pods[pod.metadata.name]"
117117
run="logCanRun.pods[pod.metadata.name]"
118118
fixed-height="250"
119-
full-log-url="(pod | navigateResourceURL) + '?view=chromeless'">
119+
full-log-url="(pod | navigateResourceURL) + '?view=chromeless'"
120+
ng-class="{'log-viewer-select': pod.spec.containers.length > 1}">
120121

121122
<span class="container-details">
122123
<label for="selectLogContainer">Container:</label>

dist/scripts/templates.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -10878,7 +10878,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
1087810878
"</div>\n" +
1087910879
"</div>\n" +
1088010880
"<div ng-repeat-end ng-if=\"expanded.pods[pod.metadata.name]\" class=\"list-group-expanded-section\" ng-class=\"{'expanded': expanded.pods[pod.metadata.name]}\">\n" +
10881-
"<log-viewer ng-if=\"'pods/log' | canI : 'get'\" object=\"pod\" context=\"projectContext\" options=\"logOptions.pods[pod.metadata.name]\" empty=\"logEmpty.pods[pod.metadata.name]\" run=\"logCanRun.pods[pod.metadata.name]\" fixed-height=\"250\" full-log-url=\"(pod | navigateResourceURL) + '?view=chromeless'\">\n" +
10881+
"<log-viewer ng-if=\"'pods/log' | canI : 'get'\" object=\"pod\" context=\"projectContext\" options=\"logOptions.pods[pod.metadata.name]\" empty=\"logEmpty.pods[pod.metadata.name]\" run=\"logCanRun.pods[pod.metadata.name]\" fixed-height=\"250\" full-log-url=\"(pod | navigateResourceURL) + '?view=chromeless'\" ng-class=\"{'log-viewer-select': pod.spec.containers.length > 1}\">\n" +
1088210882
"<span class=\"container-details\">\n" +
1088310883
"<label for=\"selectLogContainer\">Container:</label>\n" +
1088410884
"<span ng-if=\"pod.spec.containers.length === 1\">\n" +

dist/styles/main.css

+3-1
Original file line numberDiff line numberDiff line change
@@ -5251,7 +5251,7 @@ a.subtle-link:active,a.subtle-link:focus,a.subtle-link:hover{color:#00659c;borde
52515251
.log-header .log-actions .btn-link,.log-view{padding:0}
52525252
.mar-left-xxl{margin-left:30px}
52535253
.log-title{margin-top:0}
5254-
.log-header{margin-bottom:3px;margin-top:20px}
5254+
.log-header{margin-bottom:3px}
52555255
.log-header label{margin-bottom:0}
52565256
.log-header .dash{color:#9c9c9c;margin:0 2px}
52575257
.log-header .ui-select-container{min-width:150px;max-width:250px;margin:0 5px}
@@ -5263,6 +5263,8 @@ a.subtle-link:active,a.subtle-link:focus,a.subtle-link:hover{color:#00659c;borde
52635263
.log-header .log-timestamps{font-size:84%;display:inline-block}
52645264
.log-header .log-actions{float:right!important;float:right;margin-left:5px}
52655265
}
5266+
.log-viewer-select .log-header{margin-bottom:8px}
5267+
.log-viewer-select .log-actions{margin-top:5px}
52665268
.log-size-warning{margin:0}
52675269
@media (max-width:991px){.log-size-warning{margin-top:20px}
52685270
}

0 commit comments

Comments
 (0)