Skip to content

Commit d3237d4

Browse files
author
OpenShift Bot
authored
Merge pull request #1290 from spadgett/fix-add-to-project
Merged by openshift-bot
2 parents 217fa5c + 5f37a12 commit d3237d4

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

app/views/create/fromimage.html

+3-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<div ng-hide="imageStream">
1616
Loading...
1717
</div>
18-
<div class="osc-form" ng-if="imageStream">
18+
<div class="osc-form" ng-show="imageStream">
1919
<alerts alerts="alerts"></alerts>
2020
<div class="row">
2121
<div class="col-md-2 icon hidden-sm hidden-xs">
@@ -148,7 +148,8 @@
148148

149149
<!-- Use ng-show instead of ng-if so the form is still marked invalid if a hidden field has errors. -->
150150
<div ng-show="advancedOptions">
151-
<div class="form-group">
151+
<!-- Wait for project to load since the directive uses `canI` checks that need it. -->
152+
<div class="form-group" ng-if="project">
152153
<osc-secrets model="buildConfig.secrets.gitSecret"
153154
namespace="projectName"
154155
display-type="source"

dist/scripts/templates.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -5028,7 +5028,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
50285028
"<div ng-hide=\"imageStream\">\n" +
50295029
"Loading...\n" +
50305030
"</div>\n" +
5031-
"<div class=\"osc-form\" ng-if=\"imageStream\">\n" +
5031+
"<div class=\"osc-form\" ng-show=\"imageStream\">\n" +
50325032
"<alerts alerts=\"alerts\"></alerts>\n" +
50335033
"<div class=\"row\">\n" +
50345034
"<div class=\"col-md-2 icon hidden-sm hidden-xs\">\n" +
@@ -5110,7 +5110,8 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
51105110
"</div>\n" +
51115111
"\n" +
51125112
"<div ng-show=\"advancedOptions\">\n" +
5113-
"<div class=\"form-group\">\n" +
5113+
"\n" +
5114+
"<div class=\"form-group\" ng-if=\"project\">\n" +
51145115
"<osc-secrets model=\"buildConfig.secrets.gitSecret\" namespace=\"projectName\" display-type=\"source\" type=\"source\" service-account-to-link=\"builder\" secrets-by-type=\"secretsByType\" alerts=\"alerts\" allow-multiple-secrets=\"false\">\n" +
51155116
"</osc-secrets>\n" +
51165117
"</div>\n" +

0 commit comments

Comments
 (0)