Skip to content

Commit d87ad15

Browse files
author
OpenShift Bot
authored
Merge pull request #1363 from MarkDeMaria/promisesCreateFromImage
Merged by openshift-bot
2 parents ea891ff + f3eea74 commit d87ad15

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

Diff for: app/scripts/controllers/create/createFromImage.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -230,9 +230,9 @@ angular.module("openshiftConsole")
230230
$scope.memoryProblems = LimitRangesService.validatePodLimits($scope.limitRanges, 'memory', [$scope.container], project);
231231
};
232232

233-
DataService.list("limitranges", context, function(limitRanges) {
234-
$scope.limitRanges = limitRanges.by("metadata.name");
235-
if ($filter('hashSize')(limitRanges) !== 0) {
233+
DataService.list("limitranges", context).then(function(resp) {
234+
$scope.limitRanges = resp.by("metadata.name");
235+
if (!_.isEmpty($scope.limitRanges)) {
236236
$scope.$watch('container', validatePodLimits, true);
237237
}
238238
});
@@ -249,13 +249,13 @@ angular.module("openshiftConsole")
249249

250250
var quotas, clusterQuotas;
251251

252-
DataService.list("resourcequotas", context, function(quotaData) {
253-
quotas = quotaData.by("metadata.name");
252+
DataService.list("resourcequotas", context).then(function(resp) {
253+
quotas = resp.by("metadata.name");
254254
Logger.log("quotas", quotas);
255255
});
256256

257257
// TODO clean up anything not needed here
258-
DataService.list("appliedclusterresourcequotas", context, function(clusterQuotaData) {
258+
DataService.list("appliedclusterresourcequotas", context).then(function(clusterQuotaData) {
259259
clusterQuotas = clusterQuotaData.by("metadata.name");
260260
Logger.log("cluster quotas", clusterQuotas);
261261
});

Diff for: dist/scripts/scripts.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -8260,15 +8260,15 @@ a.project = e, a.breadcrumbs[0].title = r("displayName")(e), d.sourceURI && (a.s
82608260
var s = function() {
82618261
a.hideCPU || (a.cpuProblems = j.validatePodLimits(a.limitRanges, "cpu", [ a.container ], e)), a.memoryProblems = j.validatePodLimits(a.limitRanges, "memory", [ a.container ], e);
82628262
};
8263-
f.list("limitranges", g, function(b) {
8264-
a.limitRanges = b.by("metadata.name"), 0 !== r("hashSize")(b) && a.$watch("container", s, !0);
8263+
f.list("limitranges", g).then(function(b) {
8264+
a.limitRanges = b.by("metadata.name"), _.isEmpty(a.limitRanges) || a.$watch("container", s, !0);
82658265
});
82668266
var u, E, F = function() {
82678267
return a.scaling.autoscale ? void (a.showCPURequestWarning = !l.hasCPURequest([ a.container ], a.limitRanges, e)) :void (a.showCPURequestWarning = !1);
82688268
};
8269-
f.list("resourcequotas", g, function(a) {
8269+
f.list("resourcequotas", g).then(function(a) {
82708270
u = a.by("metadata.name"), b.log("quotas", u);
8271-
}), f.list("appliedclusterresourcequotas", g, function(a) {
8271+
}), f.list("appliedclusterresourcequotas", g).then(function(a) {
82728272
E = a.by("metadata.name"), b.log("cluster quotas", E);
82738273
}), a.$watch("scaling.autoscale", F), a.$watch("container", F, !0), a.$watch("name", function(a) {
82748274
A.value = a;

0 commit comments

Comments
 (0)