Skip to content

Commit dda5f7a

Browse files
author
OpenShift Bot
authored
Merge pull request #1120 from benjaminapetersen/issue-1118-env-var-edit-err
Merged by openshift-bot
2 parents b1dcc6f + 4d9518c commit dda5f7a

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

app/scripts/controllers/replicaSet.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -436,6 +436,7 @@ angular.module('openshiftConsole')
436436
deploymentConfigName = annotation(replicaSet, 'deploymentConfig');
437437
rsName = replicaSet.metadata.name;
438438
}
439+
$scope.deploymentConfigDeploymentsInProgress = $scope.deploymentConfigDeploymentsInProgress || {};
439440
if (!action) {
440441
// Loading of the page that will create deploymentConfigDeploymentsInProgress structure, which will associate running deployment to his deploymentConfig.
441442
$scope.deploymentConfigDeploymentsInProgress = DeploymentsService.associateRunningDeploymentToDeploymentConfig($scope.deploymentsByDeploymentConfig);
@@ -445,7 +446,9 @@ angular.module('openshiftConsole')
445446
$scope.deploymentConfigDeploymentsInProgress[deploymentConfigName][rsName] = replicaSet;
446447
} else if (action === 'MODIFIED') {
447448
// After the deployment ends remove him from the deploymentConfigDeploymentsInProgress structure.
448-
delete $scope.deploymentConfigDeploymentsInProgress[deploymentConfigName][rsName];
449+
if($scope.deploymentConfigDeploymentsInProgress[deploymentConfigName]) {
450+
delete $scope.deploymentConfigDeploymentsInProgress[deploymentConfigName][rsName];
451+
}
449452
}
450453

451454
// Extract the causes from the encoded deployment config

dist/scripts/scripts.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6375,7 +6375,7 @@ namespace:c.project
63756375
}), w.push(g.watch(a.resource, l, function(c, d, e) {
63766376
a.replicaSets = c.by("metadata.name"), a.emptyMessage = "No deployments to show", "ReplicationController" === r && (a.deploymentsByDeploymentConfig = h.associateDeploymentsToDeploymentConfig(a.replicaSets));
63776377
var f, g;
6378-
e && (f = t(e, "deploymentConfig"), g = e.metadata.name), d ? "ADDED" === d || "MODIFIED" === d && b("deploymentIsInProgress")(e) ? (a.deploymentConfigDeploymentsInProgress[f] = a.deploymentConfigDeploymentsInProgress[f] || {}, a.deploymentConfigDeploymentsInProgress[f][g] = e) :"MODIFIED" === d && delete a.deploymentConfigDeploymentsInProgress[f][g] :a.deploymentConfigDeploymentsInProgress = h.associateRunningDeploymentToDeploymentConfig(a.deploymentsByDeploymentConfig), e ? "DELETED" !== d && (e.causes = b("deploymentCauses")(e)) :angular.forEach(a.replicaSets, function(a) {
6378+
e && (f = t(e, "deploymentConfig"), g = e.metadata.name), a.deploymentConfigDeploymentsInProgress = a.deploymentConfigDeploymentsInProgress || {}, d ? "ADDED" === d || "MODIFIED" === d && b("deploymentIsInProgress")(e) ? (a.deploymentConfigDeploymentsInProgress[f] = a.deploymentConfigDeploymentsInProgress[f] || {}, a.deploymentConfigDeploymentsInProgress[f][g] = e) :"MODIFIED" === d && a.deploymentConfigDeploymentsInProgress[f] && delete a.deploymentConfigDeploymentsInProgress[f][g] :a.deploymentConfigDeploymentsInProgress = h.associateRunningDeploymentToDeploymentConfig(a.deploymentsByDeploymentConfig), e ? "DELETED" !== d && (e.causes = b("deploymentCauses")(e)) :angular.forEach(a.replicaSets, function(a) {
63796379
a.causes = b("deploymentCauses")(a);
63806380
});
63816381
})), w.push(g.watch("imagestreams", l, function(a) {

0 commit comments

Comments
 (0)