Skip to content

Commit e8c996a

Browse files
committed
Improve markup semantics, thusly adding bottom margin to "Create Binding" links
Fixes #2364
1 parent 0f2d9ba commit e8c996a

File tree

3 files changed

+16
-16
lines changed

3 files changed

+16
-16
lines changed

app/views/directives/service-instance-bindings.html

+4-4
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,15 @@ <h3 ng-if="$ctrl.showHeader">Bindings</h3>
77
binding="binding"
88
ref-api-object="$ctrl.serviceInstance">
99
</service-binding>
10-
<div ng-if="$ctrl.bindable">
10+
<p ng-if="$ctrl.bindable">
1111
<a href="" ng-click="$ctrl.createBinding()" role="button">
1212
<span class="pficon pficon-add-circle-o" aria-hidden="true"></span>
1313
Create Binding
1414
</a>
15-
</div>
16-
<div ng-if="!$ctrl.bindable && !($ctrl.bindings | size)">
15+
</p>
16+
<p ng-if="!$ctrl.bindable && !($ctrl.bindings | size)">
1717
<span>There are no service bindings.</span>
18-
</div>
18+
</p>
1919
</div>
2020
<overlay-panel show-panel="$ctrl.overlayPanelVisible" handle-close="$ctrl.closeOverlayPanel">
2121
<bind-service target="$ctrl.serviceInstance"

app/views/overview/_service-bindings.html

+4-4
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,16 @@
1010
service-instances="$ctrl.serviceInstances"
1111
secrets="$ctrl.secrets">
1212
</service-binding>
13-
<div ng-if="!$ctrl.refApiObject.metadata.deletionTimestamp && ($ctrl.bindableServiceInstances | size) && ({resource: 'servicebindings', group: 'servicecatalog.k8s.io'} | canI : 'create')">
13+
<p ng-if="!$ctrl.refApiObject.metadata.deletionTimestamp && ($ctrl.bindableServiceInstances | size) && ({resource: 'servicebindings', group: 'servicecatalog.k8s.io'} | canI : 'create')">
1414
<a href="" ng-click="$ctrl.createBinding()" role="button">
1515
<span class="pficon pficon-add-circle-o" aria-hidden="true"></span>
1616
Create Binding
1717
</a>
18-
</div>
19-
<div ng-if="($ctrl.refApiObject.kind !== 'ServiceInstance') && !($ctrl.bindableServiceInstances | size)">
18+
</p>
19+
<p ng-if="($ctrl.refApiObject.kind !== 'ServiceInstance') && !($ctrl.bindableServiceInstances | size)">
2020
<span>You must have a bindable service in your namespace in order to create bindings.</span>
2121
<div>
2222
<a href="./">Browse Catalog</a>
2323
</div>
24-
</div>
24+
</p>
2525
</div>

dist/scripts/templates.js

+8-8
Original file line numberDiff line numberDiff line change
@@ -9225,15 +9225,15 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
92259225
"<h3 ng-if=\"$ctrl.showHeader\">Bindings</h3>\n" +
92269226
"<service-binding ng-repeat=\"binding in $ctrl.bindings track by (binding | uid)\" is-overview=\"$ctrl.isOverview\" namespace=\"binding.metadata.namespace\" binding=\"binding\" ref-api-object=\"$ctrl.serviceInstance\">\n" +
92279227
"</service-binding>\n" +
9228-
"<div ng-if=\"$ctrl.bindable\">\n" +
9228+
"<p ng-if=\"$ctrl.bindable\">\n" +
92299229
"<a href=\"\" ng-click=\"$ctrl.createBinding()\" role=\"button\">\n" +
92309230
"<span class=\"pficon pficon-add-circle-o\" aria-hidden=\"true\"></span>\n" +
92319231
"Create Binding\n" +
92329232
"</a>\n" +
9233-
"</div>\n" +
9234-
"<div ng-if=\"!$ctrl.bindable && !($ctrl.bindings | size)\">\n" +
9233+
"</p>\n" +
9234+
"<p ng-if=\"!$ctrl.bindable && !($ctrl.bindings | size)\">\n" +
92359235
"<span>There are no service bindings.</span>\n" +
9236-
"</div>\n" +
9236+
"</p>\n" +
92379237
"</div>\n" +
92389238
"<overlay-panel show-panel=\"$ctrl.overlayPanelVisible\" handle-close=\"$ctrl.closeOverlayPanel\">\n" +
92399239
"<bind-service target=\"$ctrl.serviceInstance\" project=\"$ctrl.project\" on-close=\"$ctrl.closeOverlayPanel\"></bind-service>\n" +
@@ -12462,18 +12462,18 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
1246212462
"<div class=\"section-title hidden-xs\">{{$ctrl.sectionTitle}}</div>\n" +
1246312463
"<service-binding ng-repeat=\"binding in $ctrl.bindings track by (binding | uid)\" is-overview=\"true\" namespace=\"$ctrl.namespace\" ref-api-object=\"$ctrl.refApiObject\" binding=\"binding\" service-classes=\"$ctrl.serviceClasses\" service-instances=\"$ctrl.serviceInstances\" secrets=\"$ctrl.secrets\">\n" +
1246412464
"</service-binding>\n" +
12465-
"<div ng-if=\"!$ctrl.refApiObject.metadata.deletionTimestamp && ($ctrl.bindableServiceInstances | size) && ({resource: 'servicebindings', group: 'servicecatalog.k8s.io'} | canI : 'create')\">\n" +
12465+
"<p ng-if=\"!$ctrl.refApiObject.metadata.deletionTimestamp && ($ctrl.bindableServiceInstances | size) && ({resource: 'servicebindings', group: 'servicecatalog.k8s.io'} | canI : 'create')\">\n" +
1246612466
"<a href=\"\" ng-click=\"$ctrl.createBinding()\" role=\"button\">\n" +
1246712467
"<span class=\"pficon pficon-add-circle-o\" aria-hidden=\"true\"></span>\n" +
1246812468
"Create Binding\n" +
1246912469
"</a>\n" +
12470-
"</div>\n" +
12471-
"<div ng-if=\"($ctrl.refApiObject.kind !== 'ServiceInstance') && !($ctrl.bindableServiceInstances | size)\">\n" +
12470+
"</p>\n" +
12471+
"<p ng-if=\"($ctrl.refApiObject.kind !== 'ServiceInstance') && !($ctrl.bindableServiceInstances | size)\">\n" +
1247212472
"<span>You must have a bindable service in your namespace in order to create bindings.</span>\n" +
1247312473
"<div>\n" +
1247412474
"<a href=\"./\">Browse Catalog</a>\n" +
1247512475
"</div>\n" +
12476-
"</div>\n" +
12476+
"</p>\n" +
1247712477
"</div>"
1247812478
);
1247912479

0 commit comments

Comments
 (0)