Skip to content

Commit ea373e7

Browse files
Ensure kve does not render on browser builds if no envs to show
1 parent cf0278b commit ea373e7

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

app/views/browse/build.html

+1
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@ <h3>Environment Variables</h3>
104104
Environment variables can be edited on the <a ng-href="{{build | configURLForResource}}?tab=environment">build configuration</a>.
105105
</p>
106106
<key-value-editor
107+
ng-if="(build | buildStrategy).env"
107108
entries="(build | buildStrategy).env"
108109
key-placeholder="Name"
109110
value-placeholder="Value"

dist/scripts/templates.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -2155,7 +2155,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
21552155
"<span class=\"pficon pficon-info\" aria-hidden=\"true\"></span>\n" +
21562156
"Environment variables can be edited on the <a ng-href=\"{{build | configURLForResource}}?tab=environment\">build configuration</a>.\n" +
21572157
"</p>\n" +
2158-
"<key-value-editor entries=\"(build | buildStrategy).env\" key-placeholder=\"Name\" value-placeholder=\"Value\" cannot-add cannot-delete cannot-sort is-readonly show-header class=\"mar-bottom-xl block\"></key-value-editor>\n" +
2158+
"<key-value-editor ng-if=\"(build | buildStrategy).env\" entries=\"(build | buildStrategy).env\" key-placeholder=\"Name\" value-placeholder=\"Value\" cannot-add cannot-delete cannot-sort is-readonly show-header class=\"mar-bottom-xl block\"></key-value-editor>\n" +
21592159
"<p ng-if=\"!(build | buildStrategy).env\"><em>The build strategy had no environment variables defined.</em></p>\n" +
21602160
"</uib-tab>\n" +
21612161
"<uib-tab active=\"selectedTab.logs\" ng-if=\"!(build | isJenkinsPipelineStrategy) && ('builds/log' | canI : 'get')\">\n" +

0 commit comments

Comments
 (0)