Skip to content

Commit f30ac7b

Browse files
committed
add more detail to specific service types
Related Trello Card: https://trello.com/c/5dZkZQAX/807-2-details-on-other-service-types-kubernetes-networking This patch adds more detail, such as ingress points, to service types that support these extra fields (LoadBalancer, etc).
1 parent c6dbf16 commit f30ac7b

File tree

2 files changed

+15
-6
lines changed

2 files changed

+15
-6
lines changed

app/views/browse/service.html

+8-3
Original file line numberDiff line numberDiff line change
@@ -64,11 +64,16 @@ <h1>
6464
<dd>{{service.spec.clusterIP}}</dd>
6565
<dt>Session affinity:</dt>
6666
<dd>{{service.spec.sessionAffinity}}</dd>
67-
<dt ng-if="resource.status.loadBalancer.ingress.length">Ingress points</dt>
68-
<dd ng-if="resource.status.loadBalancer.ingress.length">
69-
<span ng-repeat="ingress in resource.status.loadBalancer.ingress"
67+
<dt ng-if="service.status.loadBalancer.ingress.length">Ingress Points:</dt>
68+
<dd ng-if="service.status.loadBalancer.ingress.length">
69+
<span ng-repeat="ingress in service.status.loadBalancer.ingress"
7070
>{{ingress.ip}}<span ng-if="!$last">, </span></span>
7171
</dd>
72+
<dt ng-if="service.spec.externalIPs.length">External IPs:</dt>
73+
<dd ng-if="service.spec.externalIPs.length">
74+
<span ng-repeat="externalIP in service.spec.externalIPs"
75+
>{{externalIP}}<span ng-if="!$last">, </span></span>
76+
</dd>
7277
<dt>Routes:</dt>
7378
<dd>
7479
<span ng-if="!routesForService.length">

dist/scripts/templates.js

+7-3
Original file line numberDiff line numberDiff line change
@@ -3472,9 +3472,13 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
34723472
"<dd>{{service.spec.clusterIP}}</dd>\n" +
34733473
"<dt>Session affinity:</dt>\n" +
34743474
"<dd>{{service.spec.sessionAffinity}}</dd>\n" +
3475-
"<dt ng-if=\"resource.status.loadBalancer.ingress.length\">Ingress points</dt>\n" +
3476-
"<dd ng-if=\"resource.status.loadBalancer.ingress.length\">\n" +
3477-
"<span ng-repeat=\"ingress in resource.status.loadBalancer.ingress\">{{ingress.ip}}<span ng-if=\"!$last\">, </span></span>\n" +
3475+
"<dt ng-if=\"service.status.loadBalancer.ingress.length\">Ingress Points:</dt>\n" +
3476+
"<dd ng-if=\"service.status.loadBalancer.ingress.length\">\n" +
3477+
"<span ng-repeat=\"ingress in service.status.loadBalancer.ingress\">{{ingress.ip}}<span ng-if=\"!$last\">, </span></span>\n" +
3478+
"</dd>\n" +
3479+
"<dt ng-if=\"service.spec.externalIPs.length\">External IPs:</dt>\n" +
3480+
"<dd ng-if=\"service.spec.externalIPs.length\">\n" +
3481+
"<span ng-repeat=\"externalIP in service.spec.externalIPs\">{{externalIP}}<span ng-if=\"!$last\">, </span></span>\n" +
34783482
"</dd>\n" +
34793483
"<dt>Routes:</dt>\n" +
34803484
"<dd>\n" +

0 commit comments

Comments
 (0)