Fix bug displaying read-only build config env vars

The read-only view was incorrectly inside a `canI : 'update'` block.

Author: spadgett

app/views/browse/build-config.html

@@ -458,16 +458,6 @@ <h3>Environment Variables</h3>
                           key-validator-error-tooltip="A valid environment variable name is an alphanumeric (a-z and 0-9) string beginning with a letter that may contain underscores."
                           add-row-link="Add Environment Variable"
                           show-header></key-value-editor>
-                        <key-value-editor
-                          ng-if="!('buildconfigs' | canI : 'update')"
-                          entries="envVars"
-                          key-placeholder="Name"
-                          value-placeholder="Value"
-                          is-readonly
-                          cannot-add
-                          cannot-sort
-                          cannot-delete
-                          show-header></key-value-editor>
                         <button
                           class="btn btn-default"
                           ng-click="saveEnvVars()"
@@ -479,6 +469,16 @@ <h3>Environment Variables</h3>
                           class="mar-left-sm"
                           style="vertical-align: -2px;">Clear Changes</a>
                       </div>
+                      <key-value-editor
+                        ng-if="!('buildconfigs' | canI : 'update')"
+                        entries="envVars"
+                        key-placeholder="Name"
+                        value-placeholder="Value"
+                        is-readonly
+                        cannot-add
+                        cannot-sort
+                        cannot-delete
+                        show-header></key-value-editor>
                     </ng-form>
                   </uib-tab>
                 </uib-tabset>

dist/scripts/templates.js

@@ -2157,10 +2157,10 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "<ng-form name=\"forms.bcEnvVars\">\n" +
     "<div ng-if=\"'buildconfigs' | canI : 'update'\">\n" +
     "<key-value-editor entries=\"envVars\" key-placeholder=\"Name\" value-placeholder=\"Value\" key-validator=\"[A-Za-z_][A-Za-z0-9_]*\" key-validator-error=\"Please enter a valid key\" key-validator-error-tooltip=\"A valid environment variable name is an alphanumeric (a-z and 0-9) string beginning with a letter that may contain underscores.\" add-row-link=\"Add Environment Variable\" show-header></key-value-editor>\n" +
-    "<key-value-editor ng-if=\"!('buildconfigs' | canI : 'update')\" entries=\"envVars\" key-placeholder=\"Name\" value-placeholder=\"Value\" is-readonly cannot-add cannot-sort cannot-delete show-header></key-value-editor>\n" +
     "<button class=\"btn btn-default\" ng-click=\"saveEnvVars()\" ng-disabled=\"forms.bcEnvVars.$pristine || forms.bcEnvVars.$invalid\">Save</button>\n" +
     "<a ng-if=\"!forms.bcEnvVars.$pristine\" href=\"\" ng-click=\"clearEnvVarUpdates()\" class=\"mar-left-sm\" style=\"vertical-align: -2px\">Clear Changes</a>\n" +
     "</div>\n" +
+    "<key-value-editor ng-if=\"!('buildconfigs' | canI : 'update')\" entries=\"envVars\" key-placeholder=\"Name\" value-placeholder=\"Value\" is-readonly cannot-add cannot-sort cannot-delete show-header></key-value-editor>\n" +
     "</ng-form>\n" +
     "</uib-tab>\n" +
     "</uib-tabset>\n" +