Skip to content

Improve service traffic table on mobile #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spadgett opened this issue Dec 13, 2016 · 2 comments · Fixed by #1042
Closed

Improve service traffic table on mobile #1031

spadgett opened this issue Dec 13, 2016 · 2 comments · Fixed by #1042
Assignees
Labels
area/styles kind/bug Categorizes issue or PR as related to a bug. priority/P3

Comments

@spadgett
Copy link
Member

Two issues:

  • It's not clear where each row ends in the mobile layout. They run together.
  • The arrows should be hidden or changed to down arrows like we do for pipelines.

Screenshot:

screen shot 2016-12-13 at 10 20 00 am

@spadgett spadgett added area/styles kind/bug Categorizes issue or PR as related to a bug. priority/P3 labels Dec 13, 2016
@spadgett
Copy link
Member Author

Also seems to be an extra table cell at the bottom.

@juanvallejo
Copy link
Contributor

@spadgett

It's not clear where each row ends in the mobile layout. They run together.

Hm, this seems to be happening because the traffic-table directive has the ng-repeat attribute on the <tr> tag rather than on the <tbody>. pods-table and app/views/browse/routes.html both have ng-repeat on the <tbody>.

cc @jwforres

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/styles kind/bug Categorizes issue or PR as related to a bug. priority/P3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants