Skip to content

Environment directive no longer in use and should be deprecated #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rhamilto opened this issue Feb 13, 2017 · 0 comments
Closed

Environment directive no longer in use and should be deprecated #1252

rhamilto opened this issue Feb 13, 2017 · 0 comments
Assignees
@rhamilto
Labels
area/techdebt priority/P3

Comments

@rhamilto
Copy link
Member

Since adding the key-value-editor, we are no longer using the environment directive. Presumably, the directive should either be commented out a la pods and podContent or removed.

See

https://github.com/openshift/origin-web-console/blob/master/app/views/directives/environment.html

and

https://github.com/openshift/origin-web-console/blob/master/app/scripts/directives/resources.js#L139-L150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhamilto rhamilto

Labels
area/techdebt priority/P3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rhamilto