Skip to content

$rootScope.$on handlers not unbound on $destroy #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spadgett opened this issue Apr 27, 2017 · 0 comments
Closed

$rootScope.$on handlers not unbound on $destroy #1480

spadgett opened this issue Apr 27, 2017 · 0 comments
Assignees
@spadgett
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P2

Comments

@spadgett
Copy link
Member

We should be unbinding our $rootScope.$on handlers when the scope is destroyed. This is a memory leak and can cause the function to run multiple times.

We have this in a few places like the pod-metrics directive.

cc @jwforres
@spadgett spadgett added kind/bug Categorizes issue or PR as related to a bug. priority/P2 labels Apr 27, 2017
@spadgett spadgett self-assigned this Apr 27, 2017
@spadgett spadgett mentioned this issue May 1, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spadgett spadgett

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spadgett