Skip to content

Adding service account a little confusing #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spadgett opened this issue Nov 8, 2016 · 8 comments
Closed

Adding service account a little confusing #850

spadgett opened this issue Nov 8, 2016 · 8 comments
Assignees
Labels
area/usability kind/bug Categorizes issue or PR as related to a bug. priority/P3
Milestone

Comments

@spadgett
Copy link
Member

spadgett commented Nov 8, 2016

The project dropdown is in the roles column, so it looks like I'm adding role oc. Also the other names have a prefix, so it looks like you should type "oc/my-name" in the input, which is an invalid name. I think we at least need labels for the inputs since they don't correspond to the column headings, or maybe move them. Placeholder text in the name input wouldn't hurt.

openshift_web_console

cc @benjaminapetersen @jwforres @ajacobs21e

@spadgett spadgett added kind/bug Categorizes issue or PR as related to a bug. priority/P3 area/usability labels Nov 8, 2016
@spadgett
Copy link
Member Author

spadgett commented Nov 8, 2016

We should also use ng-pattern for the name invalid to prevent someone submitting a value we know won't work.

@benjaminapetersen
Copy link
Contributor

Agree on both, was looking at the placement of the namespace picker as well. I think it was natural cuz it fit the space, but it is completely unintuitive.

Ill self assign.

@benjaminapetersen benjaminapetersen self-assigned this Nov 8, 2016
@spadgett
Copy link
Member Author

spadgett commented Nov 8, 2016

Should we list the service accounts in the selected namespace like we do for istag-select? It could be

openshift_web_console

Here it could be:

[Namespace] / [Service Account]

@benjaminapetersen
Copy link
Contributor

We could, just make the service accounts tab be 4 columns instead of 3. It would jitter a bit when switching from other tabs, but seems like the right way to solve.

@ajacobs21e
Copy link

I don't understand the data here so I don't have any suggestions. I'm happy to talk through it if @spadgett or @benjaminapetersen have time to explain it to me - unless you guys figured it out already?

@benjaminapetersen
Copy link
Contributor

@ajacobs21e I think @spadgett's suggestion will work great, but happy to explain anytime if you are curious!

@ajacobs21e
Copy link

@benjaminapetersen Sam's suggestion works then! thanks

@jwforres jwforres added this to the 1.5.0 milestone Jan 19, 2017
@benjaminapetersen
Copy link
Contributor

related to #1191 & can perhaps fix together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/usability kind/bug Categorizes issue or PR as related to a bug. priority/P3
Projects
None yet
Development

No branches or pull requests

4 participants