From e305ff3a9134baee8f63a365cbf14167e32e4a0e Mon Sep 17 00:00:00 2001 From: Samuel Padgett Date: Thu, 19 Oct 2017 13:35:21 -0400 Subject: [PATCH] Don't set propagationPolicy when deleting bindings --- app/scripts/services/serviceInstances.js | 7 ++++++- dist/scripts/scripts.js | 7 ++++++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/app/scripts/services/serviceInstances.js b/app/scripts/services/serviceInstances.js index 4429da98bf..9d261651a6 100644 --- a/app/scripts/services/serviceInstances.js +++ b/app/scripts/services/serviceInstances.js @@ -91,7 +91,12 @@ angular.module("openshiftConsole") return; } - DataService.delete(resource, binding.metadata.name, context) + // TODO - remove once this is resolved https://github.com/kubernetes-incubator/service-catalog/issues/942 + var opts = { + propagationPolicy: null + }; + + DataService.delete(resource, binding.metadata.name, context, opts) .then(function () { NotificationsService.addNotification({ type: "success", diff --git a/dist/scripts/scripts.js b/dist/scripts/scripts.js index 0f97d050bf..1af352b554 100644 --- a/dist/scripts/scripts.js +++ b/dist/scripts/scripts.js @@ -4370,7 +4370,11 @@ namespace: t.metadata.namespace }, l = a.getPreferredVersion("servicebindings"); p(t, n).then(function(t) { _.each(t, function(t) { -t.metadata.deletionTimestamp || i.delete(l, t.metadata.name, r).then(function() { +if (!t.metadata.deletionTimestamp) { +var n = { +propagationPolicy: null +}; +i.delete(l, t.metadata.name, r, n).then(function() { c.addNotification({ type: "success", message: "Binding " + t.metadata.name + "' was marked for deletion." @@ -4382,6 +4386,7 @@ message: "Binding " + t.metadata.name + "' could not be deleted.", details: e("getErrorDetails")(n) }), s.error("Binding " + t.metadata.name + "' could not be deleted.", n); }); +} }); }); }