Skip to content

Commit 01edb43

Browse files
author
OpenShift Bot
authored
Merge pull request #12786 from smarterclayton/fix_test_flake
Merged by openshift-bot
2 parents e2e5d9e + f27de1c commit 01edb43

File tree

1 file changed

+19
-11
lines changed

1 file changed

+19
-11
lines changed

test/extended/router/scoped.go

+19-11
Original file line numberDiff line numberDiff line change
@@ -131,13 +131,17 @@ func waitForRouterOKResponseExec(ns, execPodName, url, host string, timeoutSecon
131131
cmd := fmt.Sprintf(`
132132
set -e
133133
for i in $(seq 1 %d); do
134-
code=$( curl -s -o /dev/null -w '%%{http_code}\n' --header 'Host: %s' %q )
135-
echo $code
136-
if [[ $code -eq 200 ]]; then
137-
exit 0
138-
fi
139-
if [[ $code -ne 503 ]]; then
140-
exit 1
134+
code=$( curl -s -o /dev/null -w '%%{http_code}\n' --header 'Host: %s' %q ) || rc=$?
135+
if [[ "${rc:-0}" -eq 0 ]]; then
136+
echo $code
137+
if [[ $code -eq 200 ]]; then
138+
exit 0
139+
fi
140+
if [[ $code -ne 503 ]]; then
141+
exit 1
142+
fi
143+
else
144+
echo "error ${rc}" 1>&2
141145
fi
142146
sleep 1
143147
done
@@ -157,10 +161,14 @@ func expectRouteStatusCodeRepeatedExec(ns, execPodName, url, host string, status
157161
cmd := fmt.Sprintf(`
158162
set -e
159163
for i in $(seq 1 %d); do
160-
code=$( curl -s -o /dev/null -w '%%{http_code}\n' --header 'Host: %s' %q )
161-
echo $code
162-
if [[ $code -ne %d ]]; then
163-
exit 1
164+
code=$( curl -s -o /dev/null -w '%%{http_code}\n' --header 'Host: %s' %q ) || rc=$?
165+
if [[ "${rc:-0}" -eq 0 ]]; then
166+
echo $code
167+
if [[ $code -ne %d ]]; then
168+
exit 1
169+
fi
170+
else
171+
echo "error ${rc}" 1>&2
164172
fi
165173
done
166174
`, times, host, url, statusCode)

0 commit comments

Comments
 (0)