Skip to content

Commit 05b5e1d

Browse files
authored
Merge pull request #14907 from soltysh/issue14805
UPSTREAM: 44058: Make background garbage collection cascading
2 parents 6bbad88 + 531471d commit 05b5e1d

File tree

3 files changed

+18
-9
lines changed

3 files changed

+18
-9
lines changed

pkg/controller/controller_ref_manager.go

+2-4
Original file line numberDiff line numberDiff line change
@@ -141,13 +141,11 @@ func (m *RCControllerRefManager) AdoptReplicationController(rs *v1.ReplicationCo
141141
addControllerPatch := fmt.Sprintf(
142142
`{"metadata":{
143143
"ownerReferences":[{"apiVersion":"%s","kind":"%s","name":"%s","uid":"%s","controller":true,"blockOwnerDeletion":true}],
144-
"uid":"%s",
145-
"finalizers": ["%s"]
144+
"uid":"%s"
146145
}
147146
}`,
148147
m.controllerKind.GroupVersion(), m.controllerKind.Kind,
149-
m.Controller.GetName(), m.Controller.GetUID(), rs.UID,
150-
kmetav1.FinalizerDeleteDependents)
148+
m.Controller.GetName(), m.Controller.GetUID(), rs.UID)
151149
return m.rcControl.PatchReplicationController(rs.Namespace, rs.Name, []byte(addControllerPatch))
152150
}
153151

pkg/deploy/util/util.go

-1
Original file line numberDiff line numberDiff line change
@@ -403,7 +403,6 @@ func MakeDeploymentV1(config *deployapi.DeploymentConfig, codec runtime.Codec) (
403403
},
404404
Labels: controllerLabels,
405405
OwnerReferences: []metav1.OwnerReference{*controllerRef},
406-
Finalizers: []string{metav1.FinalizerDeleteDependents},
407406
},
408407
Spec: v1.ReplicationControllerSpec{
409408
// The deployment should be inactive initially

vendor/k8s.io/kubernetes/pkg/controller/garbagecollector/garbagecollector.go

+16-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)