Skip to content

Commit 0b74dfc

Browse files
Merge pull request #19494 from smarterclayton/vendor
Update imagebuilder to fix multistage build bugs
2 parents f3ca235 + bc371a8 commit 0b74dfc

File tree

3 files changed

+10
-14
lines changed

3 files changed

+10
-14
lines changed

glide.lock

+4-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/build/builder/dockerutil.go

+5-10
Original file line numberDiff line numberDiff line change
@@ -297,18 +297,13 @@ func buildDirectImage(dir string, ignoreFailures bool, opts *docker.BuildImageOp
297297
return err
298298
}
299299
stages := imagebuilder.NewStages(node, b)
300-
var stageExecutor *dockerclient.ClientExecutor
301-
for _, stage := range stages {
302-
stageExecutor = e.WithName(stage.Name)
303-
if err := stageExecutor.Prepare(stage.Builder, stage.Node, ""); err != nil {
304-
return err
305-
}
306-
if err := stageExecutor.Execute(stage.Builder, stage.Node); err != nil {
307-
return err
308-
}
300+
301+
lastExecutor, err := e.Stages(b, stages, "")
302+
if err != nil {
303+
return err
309304
}
310-
return stageExecutor.Commit(stages[len(stages)-1].Builder)
311305

306+
return lastExecutor.Commit(stages[len(stages)-1].Builder)
312307
})
313308
}
314309

vendor/github.com/emicklei/go-restful-swagger12/origin.sha

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)