Skip to content

Commit 1f02cb5

Browse files
Merge pull request #18761 from mfojtik/fix-dc-cancel-flake
Automatic merge from submit-queue (batch tested with PRs 18754, 18761). apps: stop dc cancellation flake This stops the flake as the conflict message has changed (?). It does not fix the root cause, which should be investigated and fixed (/cc @tnozicka) Fixes: #18743
2 parents e2e14cb + 1ba8441 commit 1f02cb5

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

test/extended/deployments/deployments.go

+3-1
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,9 @@ var _ = g.Describe("[Feature:DeploymentConfig] deploymentconfigs", func() {
125125
e2e.Logf("%02d: cancelling deployment", i)
126126
if out, err := oc.Run("rollout").Args("cancel", "dc/deployment-simple").Output(); err != nil {
127127
// TODO: we should fix this
128-
if !strings.Contains(out, "the object has been modified") && !strings.Contains(out, "there have been no replication controllers") {
128+
if !strings.Contains(out, "the object has been modified") &&
129+
!strings.Contains(out, "there have been no replication controllers") &&
130+
!strings.Contains(out, "there is a meaningful conflict") {
129131
o.Expect(err).NotTo(o.HaveOccurred())
130132
}
131133
e2e.Logf("rollout cancel deployment failed due to known safe error: %v", err)

0 commit comments

Comments
 (0)