Skip to content

Commit 27685e1

Browse files
committed
image: fix signature import from secure registries
1 parent 50389c0 commit 27685e1

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

pkg/image/controller/signature/container_image_downloader.go

+6-1
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import (
77
"time"
88

99
"github.com/containers/image/docker"
10+
"github.com/golang/glog"
1011

1112
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
1213

@@ -32,7 +33,11 @@ func (s *containerImageSignatureDownloader) DownloadImageSignatures(image *image
3233
}
3334
source, err := reference.NewImageSource(nil, nil)
3435
if err != nil {
35-
return nil, err
36+
// In case we fail to talk to registry to get the image metadata (private
37+
// registry, internal registry, etc...), do not fail with error to avoid
38+
// spamming logs.
39+
glog.V(4).Infof("Failed to get %q: %v", image.DockerImageReference, err)
40+
return []imageapi.ImageSignature{}, nil
3641
}
3742
defer source.Close()
3843

0 commit comments

Comments
 (0)