Use EqualFold instead of ToLower to reduce memory copies

Signed-off-by: Simo Sorce <[email protected]>

Author: simo5

pkg/authorization/authorizer/personal_subjectaccessreview.go

@@ -42,10 +42,10 @@ func (a *personalSARRequestInfoResolver) NewRequestInfo(req *http.Request) (*req
 	case len(requestInfo.Subresource) != 0:
 		return requestInfo, nil
 
-	case strings.ToLower(requestInfo.Verb) != "create":
+	case strings.EqualFold(requestInfo.Verb, "create") != true:
 		return requestInfo, nil
 
-	case strings.ToLower(requestInfo.Resource) != "subjectaccessreviews" && strings.ToLower(requestInfo.Resource) != "localsubjectaccessreviews":
+	case strings.EqualFold(requestInfo.Resource, "subjectaccessreviews") != true && strings.EqualFold(requestInfo.Resource, "localsubjectaccessreviews") != true:
 		return requestInfo, nil
 	}
 
@@ -76,10 +76,9 @@ func isPersonalAccessReviewFromRequest(req *http.Request, requestInfo *request.R
 	req.Body = ioutil.NopCloser(bytes.NewBuffer(body))
 
 	defaultGVK := schema.GroupVersionKind{Version: requestInfo.APIVersion, Group: requestInfo.APIGroup}
-	switch strings.ToLower(requestInfo.Resource) {
-	case "subjectaccessreviews":
+	if strings.EqualFold(requestInfo.Resource, "subjectaccessreviews") {
 		defaultGVK.Kind = "SubjectAccessReview"
-	case "localsubjectaccessreviews":
+	} else if strings.EqualFold(requestInfo.Resource, "localsubjectaccessreviews") {
 		defaultGVK.Kind = "LocalSubjectAccessReview"
 	}