Skip to content

Commit 31cfef5

Browse files
committed
Remove use of ToLower to reduce memory copies
RequestInfo always have lowercase strings in it, so no need to lower case or casefold compare anything. Signed-off-by: Simo Sorce <[email protected]>
1 parent db4d7ad commit 31cfef5

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

pkg/authorization/authorizer/personal_subjectaccessreview.go

+3-4
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import (
44
"bytes"
55
"io/ioutil"
66
"net/http"
7-
"strings"
87

98
"k8s.io/apimachinery/pkg/runtime/schema"
109
"k8s.io/apiserver/pkg/endpoints/request"
@@ -42,10 +41,10 @@ func (a *personalSARRequestInfoResolver) NewRequestInfo(req *http.Request) (*req
4241
case len(requestInfo.Subresource) != 0:
4342
return requestInfo, nil
4443

45-
case strings.ToLower(requestInfo.Verb) != "create":
44+
case requestInfo.Verb != "create":
4645
return requestInfo, nil
4746

48-
case strings.ToLower(requestInfo.Resource) != "subjectaccessreviews" && strings.ToLower(requestInfo.Resource) != "localsubjectaccessreviews":
47+
case requestInfo.Resource != "subjectaccessreviews" && requestInfo.Resource != "localsubjectaccessreviews":
4948
return requestInfo, nil
5049
}
5150

@@ -76,7 +75,7 @@ func isPersonalAccessReviewFromRequest(req *http.Request, requestInfo *request.R
7675
req.Body = ioutil.NopCloser(bytes.NewBuffer(body))
7776

7877
defaultGVK := schema.GroupVersionKind{Version: requestInfo.APIVersion, Group: requestInfo.APIGroup}
79-
switch strings.ToLower(requestInfo.Resource) {
78+
switch requestInfo.Resource {
8079
case "subjectaccessreviews":
8180
defaultGVK.Kind = "SubjectAccessReview"
8281
case "localsubjectaccessreviews":

0 commit comments

Comments
 (0)