Skip to content

Commit 3f06918

Browse files
committed
build API: mark fields related to extended builds as deprecated
1 parent 21998a2 commit 3f06918

7 files changed

+18
-12
lines changed

api/protobuf-spec/github_com_openshift_origin_pkg_build_api_v1.proto

+4-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

api/swagger-spec/oapi-v1.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -28593,7 +28593,7 @@
2859328593
"items": {
2859428594
"$ref": "runtime.RawExtension"
2859528595
},
28596-
"description": "objects is an array of resources to include in this template. If a namespace value is hardcoded in the object, it will be removed during template instantiation, however if the namespace value is, or contains, a ${PARAMETER_REFERENCE}, the resolved value after parameter substitution will be respected and the object will be created in that namespace."
28596+
"description": "objects is an array of resources to include in this template."
2859728597
},
2859828598
"parameters": {
2859928599
"type": "array",

api/swagger-spec/openshift-openapi-spec.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -56428,7 +56428,7 @@
5642856428
"$ref": "#/definitions/v1.ObjectMeta"
5642956429
},
5643056430
"objects": {
56431-
"description": "objects is an array of resources to include in this template. If a namespace value is hardcoded in the object, it will be removed during template instantiation, however if the namespace value is, or contains, a ${PARAMETER_REFERENCE}, the resolved value after parameter substitution will be respected and the object will be created in that namespace.",
56431+
"description": "objects is an array of resources to include in this template.",
5643256432
"type": "array",
5643356433
"items": {
5643456434
"$ref": "#/definitions/runtime.RawExtension"

pkg/build/api/v1/generated.proto

+4-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/build/api/v1/swagger_doc.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -460,8 +460,8 @@ var map_SourceBuildStrategy = map[string]string{
460460
"scripts": "scripts is the location of Source scripts",
461461
"incremental": "incremental flag forces the Source build to do incremental builds if true.",
462462
"forcePull": "forcePull describes if the builder should pull the images from registry prior to building.",
463-
"runtimeImage": "runtimeImage is an optional image that is used to run an application without unneeded dependencies installed. The building of the application is still done in the builder image but, post build, you can copy the needed artifacts in the runtime image for use. This field and the feature it enables are in tech preview.",
464-
"runtimeArtifacts": "runtimeArtifacts specifies a list of source/destination pairs that will be copied from the builder to the runtime image. sourcePath can be a file or directory. destinationDir must be a directory. destinationDir can also be empty or equal to \".\", in this case it just refers to the root of WORKDIR. This field and the feature it enables are in tech preview.",
463+
"runtimeImage": "runtimeImage is an optional image that is used to run an application without unneeded dependencies installed. The building of the application is still done in the builder image but, post build, you can copy the needed artifacts in the runtime image for use. Deprecated: This feature will be removed in a future release. Use ImageSource to copy binary artifacts created from one build into a separate runtime image.",
464+
"runtimeArtifacts": "runtimeArtifacts specifies a list of source/destination pairs that will be copied from the builder to the runtime image. sourcePath can be a file or directory. destinationDir must be a directory. destinationDir can also be empty or equal to \".\", in this case it just refers to the root of WORKDIR. Deprecated: This feature will be removed in a future release. Use ImageSource to copy binary artifacts created from one build into a separate runtime image.",
465465
}
466466

467467
func (SourceBuildStrategy) SwaggerDoc() map[string]string {

pkg/build/api/v1/types.go

+4-2
Original file line numberDiff line numberDiff line change
@@ -534,14 +534,16 @@ type SourceBuildStrategy struct {
534534
// without unneeded dependencies installed. The building of the application
535535
// is still done in the builder image but, post build, you can copy the
536536
// needed artifacts in the runtime image for use.
537-
// This field and the feature it enables are in tech preview.
537+
// Deprecated: This feature will be removed in a future release. Use ImageSource
538+
// to copy binary artifacts created from one build into a separate runtime image.
538539
RuntimeImage *kapi.ObjectReference `json:"runtimeImage,omitempty" protobuf:"bytes,7,opt,name=runtimeImage"`
539540

540541
// runtimeArtifacts specifies a list of source/destination pairs that will be
541542
// copied from the builder to the runtime image. sourcePath can be a file or
542543
// directory. destinationDir must be a directory. destinationDir can also be
543544
// empty or equal to ".", in this case it just refers to the root of WORKDIR.
544-
// This field and the feature it enables are in tech preview.
545+
// Deprecated: This feature will be removed in a future release. Use ImageSource
546+
// to copy binary artifacts created from one build into a separate runtime image.
545547
RuntimeArtifacts []ImageSourcePath `json:"runtimeArtifacts,omitempty" protobuf:"bytes,8,rep,name=runtimeArtifacts"`
546548
}
547549

pkg/openapi/zz_generated.openapi.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -22939,13 +22939,13 @@ var OpenAPIDefinitions *common.OpenAPIDefinitions = &common.OpenAPIDefinitions{
2293922939
},
2294022940
"runtimeImage": {
2294122941
SchemaProps: spec.SchemaProps{
22942-
Description: "runtimeImage is an optional image that is used to run an application without unneeded dependencies installed. The building of the application is still done in the builder image but, post build, you can copy the needed artifacts in the runtime image for use. This field and the feature it enables are in tech preview.",
22942+
Description: "runtimeImage is an optional image that is used to run an application without unneeded dependencies installed. The building of the application is still done in the builder image but, post build, you can copy the needed artifacts in the runtime image for use. Deprecated: This feature will be removed in a future release. Use ImageSource to copy binary artifacts created from one build into a separate runtime image.",
2294322943
Ref: spec.MustCreateRef("#/definitions/v1.ObjectReference"),
2294422944
},
2294522945
},
2294622946
"runtimeArtifacts": {
2294722947
SchemaProps: spec.SchemaProps{
22948-
Description: "runtimeArtifacts specifies a list of source/destination pairs that will be copied from the builder to the runtime image. sourcePath can be a file or directory. destinationDir must be a directory. destinationDir can also be empty or equal to \".\", in this case it just refers to the root of WORKDIR. This field and the feature it enables are in tech preview.",
22948+
Description: "runtimeArtifacts specifies a list of source/destination pairs that will be copied from the builder to the runtime image. sourcePath can be a file or directory. destinationDir must be a directory. destinationDir can also be empty or equal to \".\", in this case it just refers to the root of WORKDIR. Deprecated: This feature will be removed in a future release. Use ImageSource to copy binary artifacts created from one build into a separate runtime image.",
2294922949
Type: []string{"array"},
2295022950
Items: &spec.SchemaOrArray{
2295122951
Schema: &spec.Schema{

0 commit comments

Comments
 (0)