Fixing missing pretty logging on controller_binding. (#1520)

n3wscott · kibbles-n-bytes · commit 411831cb7c0c · 2017-11-03T13:17:47.000-07:00
diff --git a/pkg/controller/controller_binding.go b/pkg/controller/controller_binding.go
@@ -71,14 +71,18 @@ func (c *controller) bindingAdd(obj interface{}) {
 		glog.Errorf(pcb.Messagef("Couldn't get key for object %+v: %v", obj, err))
 		return
 	}
+	pcb := pretty.NewContextBuilder(pretty.ServiceBinding, "", key)
 
 	acc, err := meta.Accessor(obj)
 	if err != nil {
-		glog.Errorf("error creating meta accessor: %v", err)
+		glog.Errorf(pcb.Messagef("error creating meta accessor: %v", err))
 		return
 	}
 
-	glog.V(6).Infof("ServiceBinding %v: received ADD/UPDATE event for: resourceVersion: %v", key, acc.GetResourceVersion())
+	glog.V(6).Info(pcb.Messagef(
+		"received ADD/UPDATE event for: resourceVersion: %v",
+		acc.GetResourceVersion()),
+	)
 
 	c.bindingQueue.Add(key)
 }

Original file line number	Diff line number	Diff line change
`@@ -71,14 +71,18 @@ func (c *controller) bindingAdd(obj interface{}) {`
`71`	`71`	`glog.Errorf(pcb.Messagef("Couldn't get key for object %+v: %v", obj, err))`
`72`	`72`	`return`
`73`	`73`	`}`
	`74`	`+ pcb := pretty.NewContextBuilder(pretty.ServiceBinding, "", key)`
`74`	`75`
`75`	`76`	`acc, err := meta.Accessor(obj)`
`76`	`77`	`if err != nil {`
`77`		`- glog.Errorf("error creating meta accessor: %v", err)`
	`78`	`+ glog.Errorf(pcb.Messagef("error creating meta accessor: %v", err))`
`78`	`79`	`return`
`79`	`80`	`}`
`80`	`81`
`81`		`- glog.V(6).Infof("ServiceBinding %v: received ADD/UPDATE event for: resourceVersion: %v", key, acc.GetResourceVersion())`
	`82`	`+ glog.V(6).Info(pcb.Messagef(`
	`83`	`+ "received ADD/UPDATE event for: resourceVersion: %v",`
	`84`	`+ acc.GetResourceVersion()),`
	`85`	`+ )`
`82`	`86`
`83`	`87`	`c.bindingQueue.Add(key)`
`84`	`88`	`}`