Run reflector in a goroutine

soltysh · soltysh · commit 50e1bd3c46a0 · 2017-11-06T12:47:12.000+01:00
diff --git a/pkg/apps/strategy/support/lifecycle.go b/pkg/apps/strategy/support/lifecycle.go
@@ -467,7 +467,7 @@ func newPodWatch(client kcoreclient.PodInterface, namespace, name, resourceVersi
 	}
 
 	queue := cache.NewResyncableFIFO(cache.MetaNamespaceKeyFunc)
-	cache.NewReflector(podLW, &kapi.Pod{}, queue, 1*time.Minute).Run(stopChannel)
+	go cache.NewReflector(podLW, &kapi.Pod{}, queue, 1*time.Minute).Run(stopChannel)
 
 	return func() *kapi.Pod {
 		obj := cache.Pop(queue)
diff --git a/pkg/network/common/common.go b/pkg/network/common/common.go
@@ -188,7 +188,7 @@ func newEventQueue(client kcache.Getter, resourceName ResourceName, expectedType
 	eventQueue := NewEventQueue(DeletionHandlingMetaNamespaceKeyFunc)
 	// Repopulate event queue every 30 mins
 	// Existing items in the event queue will have watch.Modified event type
-	kcache.NewReflector(lw, expectedType, eventQueue, 30*time.Minute).Run(wait.NeverStop)
+	go kcache.NewReflector(lw, expectedType, eventQueue, 30*time.Minute).Run(wait.NeverStop)
 	return eventQueue
 }
 
diff --git a/pkg/router/template/service_lookup.go b/pkg/router/template/service_lookup.go
@@ -29,7 +29,7 @@ func NewListWatchServiceLookup(svcGetter kcoreclient.ServicesGetter, resync time
 			return svcGetter.Services(api.NamespaceAll).Watch(options)
 		},
 	}
-	cache.NewReflector(lw, &api.Service{}, svcStore, resync).Run(wait.NeverStop)
+	go cache.NewReflector(lw, &api.Service{}, svcStore, resync).Run(wait.NeverStop)
 
 	return &serviceLWLookup{
 		store: svcStore,

Original file line number	Diff line number	Diff line change
`@@ -467,7 +467,7 @@ func newPodWatch(client kcoreclient.PodInterface, namespace, name, resourceVersi`
`467`	`467`	`}`
`468`	`468`
`469`	`469`	`queue := cache.NewResyncableFIFO(cache.MetaNamespaceKeyFunc)`
`470`		`- cache.NewReflector(podLW, &kapi.Pod{}, queue, 1*time.Minute).Run(stopChannel)`
	`470`	`+ go cache.NewReflector(podLW, &kapi.Pod{}, queue, 1*time.Minute).Run(stopChannel)`
`471`	`471`
`472`	`472`	`return func() *kapi.Pod {`
`473`	`473`	`obj := cache.Pop(queue)`
Original file line number	Diff line number	Diff line change
`@@ -188,7 +188,7 @@ func newEventQueue(client kcache.Getter, resourceName ResourceName, expectedType`
`188`	`188`	`eventQueue := NewEventQueue(DeletionHandlingMetaNamespaceKeyFunc)`
`189`	`189`	`// Repopulate event queue every 30 mins`
`190`	`190`	`// Existing items in the event queue will have watch.Modified event type`
`191`		`- kcache.NewReflector(lw, expectedType, eventQueue, 30*time.Minute).Run(wait.NeverStop)`
	`191`	`+ go kcache.NewReflector(lw, expectedType, eventQueue, 30*time.Minute).Run(wait.NeverStop)`
`192`	`192`	`return eventQueue`
`193`	`193`	`}`
`194`	`194`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ func NewListWatchServiceLookup(svcGetter kcoreclient.ServicesGetter, resync time`
`29`	`29`	`return svcGetter.Services(api.NamespaceAll).Watch(options)`
`30`	`30`	`},`
`31`	`31`	`}`
`32`		`- cache.NewReflector(lw, &api.Service{}, svcStore, resync).Run(wait.NeverStop)`
	`32`	`+ go cache.NewReflector(lw, &api.Service{}, svcStore, resync).Run(wait.NeverStop)`
`33`	`33`
`34`	`34`	`return &serviceLWLookup{`
`35`	`35`	`store: svcStore,`