Skip to content

Commit 591b34d

Browse files
Fix force pull behavior in release, correct changelog gen
1 parent cf7e336 commit 591b34d

File tree

2 files changed

+6
-18
lines changed

2 files changed

+6
-18
lines changed

hack/release.sh

+4-16
Original file line numberDiff line numberDiff line change
@@ -15,22 +15,9 @@ elif [[ "$( git rev-parse "${tag}" )" != "$( git rev-parse HEAD )" ]]; then
1515
fi
1616
commit="$( git rev-parse ${tag} )"
1717

18-
function removeimage() {
19-
for i in $@; do
20-
if docker inspect $i &>/dev/null; then
21-
docker rmi $i
22-
fi
23-
if docker inspect docker.io/$i &>/dev/null; then
24-
docker rmi docker.io/$i
25-
fi
26-
done
27-
}
28-
2918
# Ensure that the build is using the latest public base images
30-
removeimage openshift/origin-base openshift/origin-release openshift/origin-haproxy-router-base
31-
docker pull openshift/origin-base
32-
docker pull openshift/origin-release
33-
docker pull openshift/origin-haproxy-router-base
19+
docker pull "openshift/origin-base:latest"
20+
docker pull "${OS_BUILD_ENV_IMAGE}"
3421

3522
OS_GIT_COMMIT="${commit}" hack/build-release.sh
3623
hack/build-images.sh
@@ -40,4 +27,5 @@ echo
4027
echo "Pushed ${tag} to DockerHub"
4128
echo "1. Push tag to GitHub with: git push origin --tags # (ensure you have no extra tags in your environment)"
4229
echo "2. Create a new release on the releases page and upload the built binaries in _output/local/releases"
43-
echo "3. Send an email"
30+
echo "3. Send an email"
31+
echo

hack/update-changelog.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,9 @@ function component() {
2828
if [[ "${new}" != "${old}" ]]; then
2929
version=$(go run tools/godepversion/godepversion.go /tmp/godeps.new $3 comment)
3030
echo "- Updated to $1 [$version + patches](https://github.com/$2/commits/$new)"
31-
git log --grep=UPSTREAM --no-merges --pretty='tformat:%H' $from..$to -- vendor/$4 | \
32-
xargs -L 1 /bin/sh -c 'echo " - $( git show -s --pretty=tformat:%s $1 | cut -f 2- -d " " ) [\\$( git log $to ^$1 --merges --ancestry-path --pretty="tformat:%s" | tail -1 | cut -f 4 -d " " )](https://github.com/$repo/pull/$( git log $to ^$1 --merges --ancestry-path --pretty="tformat:%s" | tail -1 | cut -f 4 -d " " | cut -c 2- ))"' '' | sort -n
3331
fi
32+
git log --grep=UPSTREAM --no-merges --pretty='tformat:%H' $from..$to -- vendor/$4 | \
33+
xargs -L 1 /bin/sh -c 'echo " - $( git show -s --pretty=tformat:%s $1 | cut -f 2- -d " " ) [\\$( git log $to ^$1 --merges --ancestry-path --pretty="tformat:%s" | tail -1 | cut -f 4 -d " " )](https://github.com/$repo/pull/$( git log $to ^$1 --merges --ancestry-path --pretty="tformat:%s" | tail -1 | cut -f 4 -d " " | cut -c 2- ))"' '' | sort -n
3434
fi
3535
}
3636

0 commit comments

Comments
 (0)