Skip to content

Commit 5de2606

Browse files
committed
return err on oc run --image with invalid value
1 parent 0b518a8 commit 5de2606

File tree

2 files changed

+35
-0
lines changed
  • test/cmd
  • vendor/k8s.io/kubernetes/pkg/kubectl/cmd

2 files changed

+35
-0
lines changed

test/cmd/run.sh

+25
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
#!/bin/bash
2+
3+
set -o errexit
4+
set -o nounset
5+
set -o pipefail
6+
7+
OS_ROOT=$(dirname "${BASH_SOURCE}")/../..
8+
source "${OS_ROOT}/hack/lib/init.sh"
9+
os::log::stacktrace::install
10+
trap os::test::junit::reconcile_output EXIT
11+
12+
# Cleanup cluster resources created by this test
13+
(
14+
set +e
15+
oc delete all,templates --all
16+
exit 0
17+
) &>/dev/null
18+
19+
20+
os::test::junit::declare_suite_start "cmd/newapp"
21+
# This test validates the value of --image for oc run
22+
os::cmd::expect_success_and_text 'oc run newdcforimage --image=validimagevalue' 'deploymentconfig "newdcforimage" created'
23+
os::cmd::expect_failure_and_text 'oc run newdcforimage2 --image="InvalidImageValue0192"' 'error: Invalid image name "InvalidImageValue0192": invalid reference format'
24+
echo "oc run: ok"
25+
os::test::junit::declare_suite_end

vendor/k8s.io/kubernetes/pkg/kubectl/cmd/run.go

+10
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)