Merge pull request #18785 from alexcern/18777_imagechange_initcontainers

openshift-merge-robot · web-flow · commit 6b73cc1c3d46 · 2018-03-01T10:08:14.000-08:00
Automatic merge from submit-queue (batch tested with PRs 18766, 18785). Fix initContainer name lookup for ImageChange trigger Fixes #18777 (trivial fix)
diff --git a/pkg/image/trigger/deploymentconfigs/deploymentconfigs.go b/pkg/image/trigger/deploymentconfigs/deploymentconfigs.go
@@ -66,7 +66,7 @@ func calculateDeploymentConfigTrigger(t appsapi.DeploymentTriggerPolicy, dc *app
 		})
 	}
 	for _, index := range indicesForContainerNames(dc.Spec.Template.Spec.InitContainers, t.ImageChangeParams.ContainerNames) {
-		fieldPath := fmt.Sprintf("spec.template.spec.initContainers[@name==\"%s\"].image", dc.Spec.Template.Spec.Containers[index].Name)
+		fieldPath := fmt.Sprintf("spec.template.spec.initContainers[@name==\"%s\"].image", dc.Spec.Template.Spec.InitContainers[index].Name)
 		triggers = append(triggers, triggerapi.ObjectFieldTrigger{
 			From: triggerapi.ObjectReference{
 				Name:       from.Name,

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ func calculateDeploymentConfigTrigger(t appsapi.DeploymentTriggerPolicy, dc *app`
`66`	`66`	`})`
`67`	`67`	`}`
`68`	`68`	`for _, index := range indicesForContainerNames(dc.Spec.Template.Spec.InitContainers, t.ImageChangeParams.ContainerNames) {`
`69`		`- fieldPath := fmt.Sprintf("spec.template.spec.initContainers[@name==\"%s\"].image", dc.Spec.Template.Spec.Containers[index].Name)`
	`69`	`+ fieldPath := fmt.Sprintf("spec.template.spec.initContainers[@name==\"%s\"].image", dc.Spec.Template.Spec.InitContainers[index].Name)`
`70`	`70`	`triggers = append(triggers, triggerapi.ObjectFieldTrigger{`
`71`	`71`	`From: triggerapi.ObjectReference{`
`72`	`72`	`Name: from.Name,`