Skip to content

Commit 6c84517

Browse files
Merge pull request #25985 from gabemontero/image-eco-e2e-mirror-nono
replace registry.redhat.io refs with internal image registry refs in image-eco
2 parents 993169e + a399311 commit 6c84517

File tree

2 files changed

+66
-70
lines changed

2 files changed

+66
-70
lines changed

test/extended/image_ecosystem/s2i_images.go

Lines changed: 48 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,8 @@ type tc struct {
1414
// Expected output from the command
1515
Expected string
1616

17-
// Repository is either openshift/ or rhcsl/
18-
// The default is 'openshift'
19-
Repository string
17+
// Tag is the image tag to correlates to the Version string
18+
Tag string
2019

2120
// Internal: We resolve this in JustBeforeEach
2221
DockerImageReference string
@@ -29,75 +28,75 @@ type tc struct {
2928
var s2iImages = map[string][]tc{
3029
"ruby": {
3130
{
32-
Version: "27",
33-
Cmd: "ruby --version",
34-
Expected: "ruby 2.7",
35-
Repository: "rhscl",
36-
NonAMD: true,
31+
Version: "27",
32+
Cmd: "ruby --version",
33+
Expected: "ruby 2.7",
34+
Tag: "2.7",
35+
NonAMD: true,
3736
},
3837
{
39-
Version: "26",
40-
Cmd: "ruby --version",
41-
Expected: "ruby 2.6",
42-
Repository: "rhscl",
43-
NonAMD: true,
38+
Version: "26",
39+
Cmd: "ruby --version",
40+
Expected: "ruby 2.6",
41+
Tag: "2.6",
42+
NonAMD: true,
4443
},
4544
},
4645
"python": {
4746
{
48-
Version: "27",
49-
Cmd: "python --version",
50-
Expected: "Python 2.7",
51-
Repository: "rhscl",
52-
NonAMD: true,
47+
Version: "27",
48+
Cmd: "python --version",
49+
Expected: "Python 2.7",
50+
Tag: "2.7",
51+
NonAMD: true,
5352
},
5453
{
55-
Version: "36",
56-
Cmd: "python --version",
57-
Expected: "Python 3.6",
58-
Repository: "rhscl",
59-
NonAMD: true,
54+
Version: "36",
55+
Cmd: "python --version",
56+
Expected: "Python 3.6",
57+
Tag: "3.6-ubi8",
58+
NonAMD: true,
6059
},
6160
},
6261
"nodejs": {
6362
{
64-
Version: "10",
65-
Cmd: "node --version",
66-
Expected: "v10",
67-
Repository: "rhscl",
68-
NonAMD: true,
63+
Version: "10",
64+
Cmd: "node --version",
65+
Expected: "v10",
66+
Tag: "10",
67+
NonAMD: true,
6968
},
7069
{
71-
Version: "12",
72-
Cmd: "node --version",
73-
Expected: "v12",
74-
Repository: "rhscl",
75-
NonAMD: true,
70+
Version: "12",
71+
Cmd: "node --version",
72+
Expected: "v12",
73+
Tag: "12",
74+
NonAMD: true,
7675
},
7776
},
7877
"perl": {
7978
{
80-
Version: "526",
81-
Cmd: "perl --version",
82-
Expected: "v5.26",
83-
Repository: "rhscl",
84-
NonAMD: true,
79+
Version: "526",
80+
Cmd: "perl --version",
81+
Expected: "v5.26",
82+
Tag: "5.26",
83+
NonAMD: true,
8584
},
8685
},
8786
"php": {
8887
{
89-
Version: "72",
90-
Cmd: "php --version",
91-
Expected: "7.2",
92-
Repository: "rhscl",
93-
NonAMD: true,
88+
Version: "72",
89+
Cmd: "php --version",
90+
Expected: "7.2",
91+
Tag: "7.2-ubi8",
92+
NonAMD: true,
9493
},
9594
{
96-
Version: "73",
97-
Cmd: "php --version",
98-
Expected: "7.3",
99-
Repository: "rhscl",
100-
NonAMD: true,
95+
Version: "73",
96+
Cmd: "php --version",
97+
Expected: "7.3",
98+
Tag: "7.3",
99+
NonAMD: true,
101100
},
102101
},
103102
}
@@ -115,8 +114,5 @@ func GetTestCaseForImages() map[string][]tc {
115114

116115
// resolveDockerImageReferences resolves the pull specs for all images
117116
func resolveDockerImageReference(name string, t *tc) {
118-
if len(t.Repository) == 0 {
119-
t.Repository = "openshift"
120-
}
121-
t.DockerImageReference = fmt.Sprintf("registry.redhat.io/%s/%s-%s-rhel7", t.Repository, name, t.Version)
117+
t.DockerImageReference = fmt.Sprintf("image-registry.openshift-image-registry.svc:5000/openshift/%s:%s", name, t.Tag)
122118
}

test/extended/util/annotate/generated/zz_generated.annotations.go

Lines changed: 18 additions & 18 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)