Skip to content

Commit 6d21b7d

Browse files
Merge pull request #18890 from openshift-cherrypick-robot/cherry-pick-18879-to-release-3.9
Automatic merge from submit-queue. [release-3.9] Don't try to delete (nonexistent) OVS flows for headless/external services This is an automated cherry-pick of #18879 /assign pravisankar
2 parents cb7a542 + 3628a95 commit 6d21b7d

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

pkg/network/node/node.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -473,7 +473,7 @@ func (node *OsdnNode) watchServices() {
473473

474474
func (node *OsdnNode) handleAddOrUpdateService(obj, oldObj interface{}, eventType watch.EventType) {
475475
serv := obj.(*kapi.Service)
476-
// Ignore headless services
476+
// Ignore headless/external services
477477
if !kapihelper.IsServiceIPSet(serv) {
478478
return
479479
}
@@ -499,6 +499,11 @@ func (node *OsdnNode) handleAddOrUpdateService(obj, oldObj interface{}, eventTyp
499499

500500
func (node *OsdnNode) handleDeleteService(obj interface{}) {
501501
serv := obj.(*kapi.Service)
502+
// Ignore headless/external services
503+
if !kapihelper.IsServiceIPSet(serv) {
504+
return
505+
}
506+
502507
glog.V(5).Infof("Watch %s event for Service %q", watch.Deleted, serv.Name)
503508
node.DeleteServiceRules(serv)
504509
}

0 commit comments

Comments
 (0)