Skip to content

Commit 76edd6d

Browse files
author
Ravi Sankar Penta
committed
Update stale comment: We use colon instead of underscore between namespace and route name for uniquely identifying the route in the router
1 parent 842eedc commit 76edd6d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pkg/router/template/router.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -672,10 +672,10 @@ func (r *templateRouter) routeKey(route *routeapi.Route) string {
672672
name := controller.GetSafeRouteName(route.Name)
673673

674674
// Namespace can contain dashes, so ${namespace}-${name} is not
675-
// unique, use an underscore instead - ${namespace}_${name} akin
675+
// unique, use an underscore instead - ${namespace}:${name} akin
676676
// to the way domain keys/service records use it ala
677677
// _$service.$proto.$name.
678-
// Note here that underscore (_) is not a valid DNS character and
678+
// Note here that colon (:) is not a valid DNS character and
679679
// is just used for the key name and not for the record/route name.
680680
// This also helps the use case for the key used as a router config
681681
// file name.

0 commit comments

Comments
 (0)