Skip to content

Commit 770ba8b

Browse files
author
OpenShift Bot
authored
Merge pull request #10915 from juanvallejo/jvallejo_return-err-on-oc-get-empty-list
Merged by openshift-bot
2 parents 1c5401f + 26083d5 commit 770ba8b

File tree

3 files changed

+16
-4
lines changed

3 files changed

+16
-4
lines changed

test/cmd/sdn.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ os::test::junit::declare_suite_end
4949

5050
os::test::junit::declare_suite_start "cmd/sdn/hostsubnets"
5151
# test-cmd environment has no nodes, hence no hostsubnets
52-
os::cmd::expect_success_and_not_text 'oc get hostsubnets' '.'
52+
os::cmd::expect_success_and_text 'oc get hostsubnets' 'No resources found.'
5353
os::test::junit::declare_suite_end
5454

5555
os::test::junit::declare_suite_start "cmd/sdn/egressnetworkpolicies"

test/extended/builds/remove_buildconfig.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ var _ = g.Describe("[builds][Conformance] remove all builds when build configura
4747
err = wait.Poll(3*time.Second, 3*time.Minute, func() (bool, error) {
4848
out, err := oc.Run("get").Args("-o", "name", "builds").Output()
4949
o.Expect(err).NotTo(o.HaveOccurred())
50-
if len(out) == 0 {
50+
if out == "No resources found." {
5151
return true, nil
5252
}
5353
return false, nil

vendor/k8s.io/kubernetes/pkg/kubectl/cmd/get.go

+14-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)