Skip to content

Commit 7b572df

Browse files
removing the reliance on master.NetworkInfo.ClusterNetworkCIDR
1 parent 3c83767 commit 7b572df

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

pkg/cmd/server/api/v1/conversions.go

+4-2
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,10 @@ func addDefaultingFuncs(scheme *runtime.Scheme) error {
9595

9696
if noCloudProvider && len(obj.NetworkConfig.IngressIPNetworkCIDR) == 0 {
9797
cidr := internal.DefaultIngressIPNetworkCIDR
98-
if !(internal.CIDRsOverlap(cidr, obj.NetworkConfig.ClusterNetworkCIDR) || internal.CIDRsOverlap(cidr, obj.NetworkConfig.ServiceNetworkCIDR)) {
99-
obj.NetworkConfig.IngressIPNetworkCIDR = cidr
98+
for _, entry := range obj.NetworkConfig.ClusterNetworks {
99+
if !(internal.CIDRsOverlap(cidr, entry.CIDR) || internal.CIDRsOverlap(cidr, obj.NetworkConfig.ServiceNetworkCIDR)) {
100+
obj.NetworkConfig.IngressIPNetworkCIDR = cidr
101+
}
100102
}
101103
}
102104

pkg/cmd/server/api/validation/master.go

+4-2
Original file line numberDiff line numberDiff line change
@@ -766,8 +766,10 @@ func ValidateIngressIPNetworkCIDR(config *api.MasterConfig, fldPath *field.Path)
766766
noCloudProvider := kubeConfig != nil && (len(kubeConfig.ControllerArguments["cloud-provider"]) == 0 || kubeConfig.ControllerArguments["cloud-provider"][0] == "")
767767

768768
if noCloudProvider {
769-
if api.CIDRsOverlap(cidr, config.NetworkConfig.ClusterNetworkCIDR) {
770-
addError("conflicts with cluster network CIDR")
769+
for _, entry := range config.NetworkConfig.ClusterNetworks {
770+
if api.CIDRsOverlap(cidr, entry.CIDR) {
771+
addError("conflicts with cluster network CIDR")
772+
}
771773
}
772774
if api.CIDRsOverlap(cidr, config.NetworkConfig.ServiceNetworkCIDR) {
773775
addError("conflicts with service network CIDR")

0 commit comments

Comments
 (0)