Do not overwrite by default in create-{server|signer}-cert

This change updates the oc adm ca create-{server|signer}-cert
commands to not overwrite existing cert files.  Thus the new default
is to leave any existing file as-is.

Bug 1512825

Signed-off-by: Monis Khan <[email protected]>

Author: enj

pkg/cmd/server/admin/create_servercert.go

@@ -76,7 +76,7 @@ func NewCommandCreateServerCert(commandName string, fullName string, out io.Writ
 	flags.StringVar(&options.KeyFile, "key", "", "The key file. Choose a name that indicates what the service is.")
 
 	flags.StringSliceVar(&options.Hostnames, "hostnames", options.Hostnames, "Every hostname or IP you want server certs to be valid for. Comma delimited list")
-	flags.BoolVar(&options.Overwrite, "overwrite", true, "Overwrite existing cert files if found.  If false, any existing file will be left as-is.")
+	flags.BoolVar(&options.Overwrite, "overwrite", false, "Overwrite existing cert files if found.  If false, any existing file will be left as-is.")
 
 	flags.IntVar(&options.ExpireDays, "expire-days", options.ExpireDays, "Validity of the certificate in days (defaults to 2 years). WARNING: extending this above default value is highly discouraged.")
 

pkg/cmd/server/admin/create_signercert.go

@@ -52,7 +52,7 @@ func NewCommandCreateSignerCert(commandName string, fullName string, out io.Writ
 	options := &CreateSignerCertOptions{
 		ExpireDays: crypto.DefaultCACertificateLifetimeInDays,
 		Output:     out,
-		Overwrite:  true,
+		Overwrite:  false,
 	}
 
 	cmd := &cobra.Command{