Merge pull request #26921 from dgoodwin/related-obj-tests

Add test for validating related object references.

Author: openshift-merge-robot

test/extended/operators/clusteroperators.go

@@ -2,13 +2,14 @@ package operators
 
 import (
 	"context"
+	"strings"
 
 	g "github.com/onsi/ginkgo"
 	o "github.com/onsi/gomega"
 	s "github.com/onsi/gomega/gstruct"
 	t "github.com/onsi/gomega/types"
-
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/runtime/schema"
 	"k8s.io/kube-openapi/pkg/util/sets"
 	e2e "k8s.io/kubernetes/test/e2e/framework"
 
@@ -81,6 +82,47 @@ var _ = g.Describe("[sig-arch] ClusterOperators", func() {
 			}
 		})
 
+		g.Specify("valid related objects", func() {
+			controlplaneTopology, err := exutil.GetControlPlaneTopology(oc)
+			o.Expect(err).NotTo(o.HaveOccurred())
+			if *controlplaneTopology == config.ExternalTopologyMode {
+				// The packageserver runs in a different cluster along the other controlplane components
+				// when the controlplane is external.
+				whitelistNoOperatorConfig.Insert("operator-lifecycle-manager-packageserver")
+			}
+			restMapper := oc.RESTMapper()
+
+			for _, clusterOperator := range clusterOperators {
+				if !whitelistNoOperatorConfig.Has(clusterOperator.Name) {
+					for _, relatedObj := range clusterOperator.Status.RelatedObjects {
+
+						// any uppercase immediately signals an improper mapping:
+						o.Expect(relatedObj.Resource).To(o.Equal(strings.ToLower(relatedObj.Resource)),
+							"Cluster operator %s should be using lowercase resource references: %s",
+							clusterOperator.Name, relatedObj.Resource)
+
+						// also ensure we find a valid rest mapping:
+
+						// "storage" ClusterOperator has some relatedResource refs to CRDs that only exists if
+						// TechPreviewNoUpgrade is enabled. This is acceptable and not a bug, but needs a special case here.
+						if clusterOperator.Name == "storage" && (relatedObj.Resource == "sharedconfigmaps" ||
+							relatedObj.Resource == "sharedsecrets") {
+							continue
+						}
+
+						resourceMatches, err := restMapper.ResourcesFor(schema.GroupVersionResource{
+							Group:    relatedObj.Group,
+							Resource: relatedObj.Resource,
+						})
+						o.Expect(err).ToNot(o.HaveOccurred())
+						o.Expect(len(resourceMatches)).To(o.BeNumerically(">", 0),
+							"No valid rest mapping found for cluster operator %s related object %s",
+							clusterOperator.Name, relatedObj.Resource)
+					}
+				}
+			}
+		})
+
 	})
 })