Skip to content

Commit 83c5b09

Browse files
author
OpenShift Bot
authored
Merge pull request #10684 from DirectXMan12/bug/oc-scale-dc-3.1
Merged by openshift-bot
2 parents aa4ddb9 + 0851ee7 commit 83c5b09

File tree

1 file changed

+2
-9
lines changed

1 file changed

+2
-9
lines changed

pkg/deploy/cmd/scale.go

+2-9
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
package cmd
22

33
import (
4-
"fmt"
5-
"os"
64
"time"
75

86
kapi "k8s.io/kubernetes/pkg/api"
@@ -11,7 +9,6 @@ import (
119
"k8s.io/kubernetes/pkg/util/wait"
1210

1311
"github.com/openshift/origin/pkg/client"
14-
deployapi "github.com/openshift/origin/pkg/deploy/api"
1512
"github.com/openshift/origin/pkg/deploy/util"
1613
)
1714

@@ -61,17 +58,13 @@ func (scaler *DeploymentConfigScaler) Scale(namespace, name string, newSize uint
6158
// ScaleSimple does a simple one-shot attempt at scaling - not useful on its
6259
// own, but a necessary building block for Scale
6360
func (scaler *DeploymentConfigScaler) ScaleSimple(namespace, name string, preconditions *kubectl.ScalePrecondition, newSize uint) error {
64-
dc, err := scaler.dcClient.DeploymentConfigs(namespace).Get(name)
61+
scale, err := scaler.dcClient.DeploymentConfigs(namespace).GetScale(name)
6562
if err != nil {
6663
return err
6764
}
68-
if dc.Spec.Test {
69-
fmt.Fprintln(os.Stderr, "Replica size for a test deployment applies only when the deployment is running.")
70-
}
71-
scale := deployapi.ScaleFromConfig(dc)
7265
scale.Spec.Replicas = int32(newSize)
7366
if _, err := scaler.dcClient.DeploymentConfigs(namespace).UpdateScale(scale); err != nil {
74-
return kubectl.ScaleError{FailureType: kubectl.ScaleUpdateFailure, ResourceVersion: dc.ResourceVersion, ActualError: err}
67+
return kubectl.ScaleError{FailureType: kubectl.ScaleUpdateFailure, ResourceVersion: "Unknown", ActualError: err}
7568
}
7669
return nil
7770
}

0 commit comments

Comments
 (0)