Skip to content

Commit 83e3250

Browse files
author
OpenShift Bot
authored
Merge pull request #13647 from csrwng/clusterup_router_cert
Merged by openshift-bot
2 parents 8a05370 + a9f6c9e commit 83e3250

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

pkg/bootstrap/docker/openshift/admin.go

+7-2
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,11 @@ func (h *Helper) InstallRouter(kubeClient kclientset.Interface, f *clientcmd.Fac
110110
return errors.NewError("cannot update privileged SCC").WithCause(err).WithDetails(h.OriginLog())
111111
}
112112

113+
routingSuffix := h.routingSuffix
114+
if len(routingSuffix) == 0 {
115+
routingSuffix = fmt.Sprintf("%s.nip.io", hostIP)
116+
}
117+
113118
// Create router cert
114119
cmdOutput := &bytes.Buffer{}
115120
createCertOptions := &admin.CreateServerCertOptions{
@@ -120,10 +125,10 @@ func (h *Helper) InstallRouter(kubeClient kclientset.Interface, f *clientcmd.Fac
120125
},
121126
Overwrite: true,
122127
Hostnames: []string{
123-
fmt.Sprintf("%s.nip.io", hostIP),
128+
routingSuffix,
124129
// This will ensure that routes using edge termination and the default
125130
// certs will use certs valid for their arbitrary subdomain names.
126-
fmt.Sprintf("*.%s.nip.io", hostIP),
131+
fmt.Sprintf("*.%s", routingSuffix),
127132
},
128133
CertFile: filepath.Join(masterDir, "router.crt"),
129134
KeyFile: filepath.Join(masterDir, "router.key"),

0 commit comments

Comments
 (0)