Skip to content

Commit 90acf16

Browse files
author
Jim Minter
committed
ignore API server timeout errors in templateinstance controller readiness checking
1 parent 233358f commit 90acf16

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

pkg/template/controller/templateinstance_controller.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,9 @@ func (c *TemplateInstanceController) sync(key string) error {
157157

158158
if !templateInstance.HasCondition(templateapi.TemplateInstanceInstantiateFailure, kapi.ConditionTrue) {
159159
ready, err := c.checkReadiness(templateInstance, time.Now())
160-
if err != nil {
160+
if err != nil && !kerrors.IsTimeout(err) {
161+
// NB: kerrors.IsTimeout() is true in the case of an API server
162+
// timeout, not the timeout caused by readinessTimeout expiring.
161163
glog.V(4).Infof("TemplateInstance controller: checkReadiness %s returned %v", key, err)
162164

163165
templateInstance.SetCondition(templateapi.TemplateInstanceCondition{

0 commit comments

Comments
 (0)